fix: prevent null release date field in xblocks#763
Merged
viadanna merged 1 commit intoopencraft-release/redwood.1from May 23, 2025
Merged
fix: prevent null release date field in xblocks#763viadanna merged 1 commit intoopencraft-release/redwood.1from
viadanna merged 1 commit intoopencraft-release/redwood.1from
Conversation
kaustavb12
approved these changes
Apr 9, 2025
Member
kaustavb12
left a comment
kaustavb12
left a comment
There was a problem hiding this comment.
👍
- I tested this: Tested in sandbox
- I read through the code
- I checked for accessibility issues
- Includes documentation
viadanna
merged commit cab37b5
into
opencraft-release/redwood.1
40 of 116 checks passed
Member
|
@kaustavb12 @viadanna I checked upstream and I don't see this issue fixed. I assume that we are going to need this in Teak, so we would have to cherry-pick this commit, right? If so, can you please create an upstream PR? |
Member
|
Upstream PR: openedx#37299 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The change prevents setting the release date to null by removing the field and inheriting from the parent instead.
cms/djangoapps/contentstore/xblock_storage_handlers/view_handlers.py: Added a check to prevent setting the release date to null.Ref: BB-9629