Repository navigation
fix: use correct entity field names in domain provider stats query - #49
Merged
Merged
Conversation
![rootminster-bot[bot]](https://github.githubassets.com/images/gravatars/gravatar-user-420.png){kind=avatar}
SubdomainRequest stores the domain in 'root_domain', DnsRecord uses 'zone_name'. The previous query filtered on data->>'domain' which matches neither, so all counts (active subdomains, pending requests, new 7d, managed DNS records) returned 0 for every domain. Fix: - WHERE clause now matches each entity type against its own field - GROUP BY / SELECT use COALESCE(root_domain, zone_name) as the key - Verified against production data: is-not-a.dev returns 111 approved, 3 pending, 165 managed DNS records (vs 0 for all before this fix)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
Active Subdomains, Pending Requests, New (7 days), and managed DNS Records all showed 0 despite real data existing in
entity_records.Root cause
The stats query filtered and grouped on
data->>'domain', but neither entity type stores the domain name under that key:SubdomainRequestroot_domainDnsRecordzone_nameBecause no rows matched
data->>'domain' = ANY(...), every aggregate came back 0.Fix
root_domain/zone_name)COALESCE(data->>'root_domain', data->>'zone_name')as the per-domain keyVerified against production
For
is-not-a.devthe corrected query returns:(Previously all 0.)
Checks