Skip to content

Fix DLL output paths on Windows #500

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
tbujewsk merged 1 commit into from
Jan 8, 2026
Merged

Fix DLL output paths on Windows #500

tbujewsk merged 1 commit into from
Jan 8, 2026
+20 −11

Conversation

@yunowo
Copy link
Member

@yunowo yunowo commented Jan 4, 2026 •
edited
Loading

Currently there can be 4 folders for Release/Debug dll output on Windows, which is very confusing.

build\intel64\Release\bin\Release
build\intel64\Release\bin\Debug
build\intel64\Debug\bin\Debug
build\intel64\Debug\bin\Release

This PR removes the last build type and aligns to Linux paths. The result is

build\intel64\Release\bin
build\intel64\Debug\bin

Also updated configure_file command's paths because it does not support generator expressions.

@yunowo yunowo marked this pull request as ready for review January 4, 2026 06:12
@tbujewsk
Copy link
Contributor

tbujewsk commented Jan 8, 2026

Is there any documentation update required ?

@yunowo
Copy link
Member Author

yunowo commented Jan 8, 2026

Is there any documentation update required ?

No. I didn't see any documentation refers to this path

@tbujewsk tbujewsk merged commit 344c11a into master Jan 8, 2026
19 of 22 checks passed
@tbujewsk tbujewsk deleted the fix-dll-path branch January 8, 2026 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tbujewsk tbujewsk tbujewsk approved these changes

@BaoHuiling BaoHuiling BaoHuiling approved these changes

@dmichalo dmichalo dmichalo approved these changes

@OskarFiedot OskarFiedot Awaiting requested review from OskarFiedot OskarFiedot is a code owner

@marcin-wadolkowski marcin-wadolkowski Awaiting requested review from marcin-wadolkowski marcin-wadolkowski is a code owner

@nszczygl9 nszczygl9 Awaiting requested review from nszczygl9 nszczygl9 is a code owner

@msmiatac msmiatac Awaiting requested review from msmiatac msmiatac is a code owner

@jmotow jmotow Awaiting requested review from jmotow jmotow is a code owner

@pbartosik pbartosik Awaiting requested review from pbartosik pbartosik is a code owner

@mholowni mholowni Awaiting requested review from mholowni mholowni is a code owner

@qianlongding qianlongding Awaiting requested review from qianlongding qianlongding is a code owner

@ZiningLi ZiningLi Awaiting requested review from ZiningLi ZiningLi is a code owner

@yangjianfeng1208 yangjianfeng1208 Awaiting requested review from yangjianfeng1208 yangjianfeng1208 is a code owner

@oonyshch oonyshch Awaiting requested review from oonyshch oonyshch is a code owner

@walidbarakat walidbarakat Awaiting requested review from walidbarakat walidbarakat is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@yunowo @tbujewsk @BaoHuiling @dmichalo