-
Notifications
You must be signed in to change notification settings - Fork 185
Modify shellcheck action and fix shellcheck findings (errors only). #515
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit
shellcheck
📝 [shellcheck] reported by reviewdog 🐶
Not following: ./bin/activate: openBinaryFile: does not exist (No such file or directory) SC1091
dlstreamer/samples/download_public_models.sh
Line 603 in 235552a
| source "$VENV_DIR/bin/activate" |
📝 [shellcheck] reported by reviewdog 🐶
Not following: ./bin/activate: openBinaryFile: does not exist (No such file or directory) SC1091
dlstreamer/samples/download_public_models.sh
Line 641 in 235552a
| source "$VENV_DIR/bin/activate" |
📝 [shellcheck] reported by reviewdog 🐶
Not following: ./bin/activate: openBinaryFile: does not exist (No such file or directory) SC1091
dlstreamer/samples/download_public_models.sh
Line 791 in 235552a
| source "$VENV_DIR/bin/activate" |
📝 [shellcheck] reported by reviewdog 🐶
Not following: ./bin/activate: openBinaryFile: does not exist (No such file or directory) SC1091
dlstreamer/samples/download_public_models.sh
Line 837 in 235552a
| source "$VENV_DIR/bin/activate" |
📝 [shellcheck] reported by reviewdog 🐶
Not following: ./bin/activate: openBinaryFile: does not exist (No such file or directory) SC1091
dlstreamer/samples/download_public_models.sh
Line 883 in 235552a
| source "$VENV_DIR/bin/activate" |
📝 [shellcheck] reported by reviewdog 🐶
Not following: ./bin/activate: openBinaryFile: does not exist (No such file or directory) SC1091
dlstreamer/samples/download_public_models.sh
Line 940 in 235552a
| source "$VENV_DIR/bin/activate" |
📝 [shellcheck] reported by reviewdog 🐶
Not following: ./bin/activate: openBinaryFile: does not exist (No such file or directory) SC1091
dlstreamer/samples/download_public_models.sh
Line 1022 in 235552a
| source "$VENV_DIR/bin/activate" |
📝 [shellcheck] reported by reviewdog 🐶
Double quote to prevent globbing and word splitting. SC2086
dlstreamer/samples/download_public_models.sh
Line 1046 in 235552a
| rm -r $VENV_DIR |
📝 [shellcheck] reported by reviewdog 🐶
Double quote to prevent globbing and word splitting. SC2086
dlstreamer/samples/download_public_models.sh
Line 1047 in 235552a
| rm -r $VENV_DIR_QUANT |
Use 'pushd ... || exit' or 'pushd ... || return' in case pushd fails. SC2164
| pushd "${SOURCE_DIR}" |
Use 'popd ... || exit' or 'popd ... || return' in case popd fails. SC2164
📝 [shellcheck] reported by reviewdog 🐶
Double quote to prevent globbing and word splitting. SC2086
| update_output=$(timeout --foreground $APT_UPDATE_TIMEOUT $SUDO_PREFIX apt-get update 2>&1) |
📝 [shellcheck] reported by reviewdog 🐶
Double quote to prevent globbing and word splitting. SC2086
| timeout --foreground $APT_GET_TIMEOUT $SUDO_PREFIX apt-get install -y --allow-downgrades "$@" 2>&1 | tee "$log_file" |
📝 [shellcheck] reported by reviewdog 🐶
Double quote to prevent globbing and word splitting. SC2086
| $SUDO_PREFIX add-apt-repository -y $INTEL_CL_GPU_REPO_URL |
📝 [shellcheck] reported by reviewdog 🐶
Double quote to prevent globbing and word splitting. SC2086
| echo "Snapshot: 20251125T030400Z" | $SUDO_PREFIX tee -a /etc/apt/sources.list.d/$INTEL_GPU_LIST |
📝 [shellcheck] reported by reviewdog 🐶
Use ./glob or -- glob so names with dashes won't become options. SC2035
| $SUDO_PREFIX $SUDO_PREFIX dpkg -i *.deb |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit
shellcheck
Use 'popd ... || exit' or 'popd ... || return' in case popd fails. SC2164
📝 [shellcheck] reported by reviewdog 🐶
Double quote to prevent globbing and word splitting. SC2086
| update_output=$(timeout --foreground $APT_UPDATE_TIMEOUT $SUDO_PREFIX apt-get update 2>&1) |
📝 [shellcheck] reported by reviewdog 🐶
Double quote to prevent globbing and word splitting. SC2086
| timeout --foreground $APT_GET_TIMEOUT $SUDO_PREFIX apt-get install -y --allow-downgrades "$@" 2>&1 | tee "$log_file" |
📝 [shellcheck] reported by reviewdog 🐶
Double quote to prevent globbing and word splitting. SC2086
| $SUDO_PREFIX add-apt-repository -y $INTEL_CL_GPU_REPO_URL |
📝 [shellcheck] reported by reviewdog 🐶
Double quote to prevent globbing and word splitting. SC2086
| echo "Snapshot: 20251125T030400Z" | $SUDO_PREFIX tee -a /etc/apt/sources.list.d/$INTEL_GPU_LIST |
📝 [shellcheck] reported by reviewdog 🐶
Use ./glob or -- glob so names with dashes won't become options. SC2035
| $SUDO_PREFIX $SUDO_PREFIX dpkg -i *.deb |
Description
Please include a summary of the changes and the related issue. List any dependencies that are required for this change.
Fixes # (issue)
Any Newly Introduced Dependencies
Please describe any newly introduced 3rd party dependencies in this change. List their name, license information and how they are used in the project.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist: