Skip to content

Conversation

@nszczygl9
Copy link
Contributor

Description

Please include a summary of the changes and the related issue. List any dependencies that are required for this change.

Fixes # (issue)

Any Newly Introduced Dependencies

Please describe any newly introduced 3rd party dependencies in this change. List their name, license information and how they are used in the project.

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Checklist:

  • I agree to use the MIT license for my code changes.
  • I have not introduced any 3rd party components incompatible with MIT.
  • I have not included any company confidential information, trade secret, password or security token.
  • I have performed a self-review of my code.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit

shellcheck

📝 [shellcheck] reported by reviewdog 🐶
Not following: ./bin/activate: openBinaryFile: does not exist (No such file or directory) SC1091

source "$VENV_DIR/bin/activate"


📝 [shellcheck] reported by reviewdog 🐶
Not following: ./bin/activate: openBinaryFile: does not exist (No such file or directory) SC1091

source "$VENV_DIR/bin/activate"


📝 [shellcheck] reported by reviewdog 🐶
Not following: ./bin/activate: openBinaryFile: does not exist (No such file or directory) SC1091

source "$VENV_DIR/bin/activate"


📝 [shellcheck] reported by reviewdog 🐶
Not following: ./bin/activate: openBinaryFile: does not exist (No such file or directory) SC1091

source "$VENV_DIR/bin/activate"


📝 [shellcheck] reported by reviewdog 🐶
Not following: ./bin/activate: openBinaryFile: does not exist (No such file or directory) SC1091

source "$VENV_DIR/bin/activate"


📝 [shellcheck] reported by reviewdog 🐶
Not following: ./bin/activate: openBinaryFile: does not exist (No such file or directory) SC1091

source "$VENV_DIR/bin/activate"


📝 [shellcheck] reported by reviewdog 🐶
Not following: ./bin/activate: openBinaryFile: does not exist (No such file or directory) SC1091

source "$VENV_DIR/bin/activate"


📝 [shellcheck] reported by reviewdog 🐶
Double quote to prevent globbing and word splitting. SC2086


📝 [shellcheck] reported by reviewdog 🐶
Double quote to prevent globbing and word splitting. SC2086

rm -r $VENV_DIR_QUANT


⚠️ [shellcheck] reported by reviewdog 🐶
Use 'pushd ... || exit' or 'pushd ... || return' in case pushd fails. SC2164


⚠️ [shellcheck] reported by reviewdog 🐶
Use 'popd ... || exit' or 'popd ... || return' in case popd fails. SC2164


📝 [shellcheck] reported by reviewdog 🐶
Double quote to prevent globbing and word splitting. SC2086

update_output=$(timeout --foreground $APT_UPDATE_TIMEOUT $SUDO_PREFIX apt-get update 2>&1)


📝 [shellcheck] reported by reviewdog 🐶
Double quote to prevent globbing and word splitting. SC2086

timeout --foreground $APT_GET_TIMEOUT $SUDO_PREFIX apt-get install -y --allow-downgrades "$@" 2>&1 | tee "$log_file"


📝 [shellcheck] reported by reviewdog 🐶
Double quote to prevent globbing and word splitting. SC2086

$SUDO_PREFIX add-apt-repository -y $INTEL_CL_GPU_REPO_URL


📝 [shellcheck] reported by reviewdog 🐶
Double quote to prevent globbing and word splitting. SC2086

echo "Snapshot: 20251125T030400Z" | $SUDO_PREFIX tee -a /etc/apt/sources.list.d/$INTEL_GPU_LIST


📝 [shellcheck] reported by reviewdog 🐶
Use ./glob or -- glob so names with dashes won't become options. SC2035

$SUDO_PREFIX $SUDO_PREFIX dpkg -i *.deb

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit

shellcheck

⚠️ [shellcheck] reported by reviewdog 🐶
Use 'popd ... || exit' or 'popd ... || return' in case popd fails. SC2164


📝 [shellcheck] reported by reviewdog 🐶
Double quote to prevent globbing and word splitting. SC2086

update_output=$(timeout --foreground $APT_UPDATE_TIMEOUT $SUDO_PREFIX apt-get update 2>&1)


📝 [shellcheck] reported by reviewdog 🐶
Double quote to prevent globbing and word splitting. SC2086

timeout --foreground $APT_GET_TIMEOUT $SUDO_PREFIX apt-get install -y --allow-downgrades "$@" 2>&1 | tee "$log_file"


📝 [shellcheck] reported by reviewdog 🐶
Double quote to prevent globbing and word splitting. SC2086

$SUDO_PREFIX add-apt-repository -y $INTEL_CL_GPU_REPO_URL


📝 [shellcheck] reported by reviewdog 🐶
Double quote to prevent globbing and word splitting. SC2086

echo "Snapshot: 20251125T030400Z" | $SUDO_PREFIX tee -a /etc/apt/sources.list.d/$INTEL_GPU_LIST


📝 [shellcheck] reported by reviewdog 🐶
Use ./glob or -- glob so names with dashes won't become options. SC2035

$SUDO_PREFIX $SUDO_PREFIX dpkg -i *.deb

@nszczygl9 nszczygl9 merged commit cf40de0 into master Jan 9, 2026
35 of 40 checks passed
@nszczygl9 nszczygl9 deleted the nsz-fix-shellcheck branch January 9, 2026 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants