[DLStreamer] fixed some pylint problems #1177
Conversation
marcin-wadolkowski
requested review from
a team,
OskarFiedot,
dmichalo,
jmotow,
mholowni,
msmiatac,
nszczygl9,
pbartosik and
tbujewsk
as code owners
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit
pylint
libraries/dl-streamer/docs/scripts/generate_models_table.py|271 col 12| C0209: Formatting a regular string which could be an f-string (consider-using-f-string)
libraries/dl-streamer/docs/scripts/generate_models_table.py|285 col 12| C0209: Formatting a regular string which could be an f-string (consider-using-f-string)
libraries/dl-streamer/docs/scripts/generate_models_table.py|300 col 16| C0209: Formatting a regular string which could be an f-string (consider-using-f-string)
libraries/dl-streamer/docs/scripts/generate_models_table.py|301 col 16| C0209: Formatting a regular string which could be an f-string (consider-using-f-string)
libraries/dl-streamer/docs/scripts/generate_models_table.py|302 col 16| C0209: Formatting a regular string which could be an f-string (consider-using-f-string)
libraries/dl-streamer/docs/scripts/generate_models_table.py|303 col 16| C0209: Formatting a regular string which could be an f-string (consider-using-f-string)
libraries/dl-streamer/docs/scripts/generate_models_table.py|304 col 16| C0209: Formatting a regular string which could be an f-string (consider-using-f-string)
libraries/dl-streamer/docs/scripts/generate_models_table.py|308 col 16| C0209: Formatting a regular string which could be an f-string (consider-using-f-string)
libraries/dl-streamer/docs/scripts/generate_models_table.py|309 col 16| C0209: Formatting a regular string which could be an f-string (consider-using-f-string)
libraries/dl-streamer/docs/scripts/generate_models_table.py|310 col 16| C0209: Formatting a regular string which could be an f-string (consider-using-f-string)
libraries/dl-streamer/docs/scripts/generate_models_table.py|311 col 16| C0209: Formatting a regular string which could be an f-string (consider-using-f-string)
libraries/dl-streamer/docs/scripts/generate_models_table.py|314 col 20| C0209: Formatting a regular string which could be an f-string (consider-using-f-string)
libraries/dl-streamer/docs/scripts/generate_models_table.py|320 col 20| C0209: Formatting a regular string which could be an f-string (consider-using-f-string)
libraries/dl-streamer/docs/scripts/generate_models_table.py|323 col 16| C0209: Formatting a regular string which could be an f-string (consider-using-f-string)
libraries/dl-streamer/docs/scripts/models_table_from_yaml.py|48| C0301: Line too long (114/100) (line-too-long)
libraries/dl-streamer/docs/scripts/models_table_from_yaml.py|52| C0301: Line too long (114/100) (line-too-long)
libraries/dl-streamer/docs/scripts/models_table_from_yaml.py|124| C0301: Line too long (122/100) (line-too-long)
libraries/dl-streamer/docs/scripts/models_table_from_yaml.py|152| C0301: Line too long (110/100) (line-too-long)
libraries/dl-streamer/docs/scripts/models_table_from_yaml.py|155| C0301: Line too long (109/100) (line-too-long)
libraries/dl-streamer/docs/scripts/models_table_from_yaml.py|15| C0103: Constant name "dldt_str" doesn't conform to UPPER_CASE naming style (invalid-name)
libraries/dl-streamer/docs/scripts/models_table_from_yaml.py|16| C0103: Constant name "openvino_str" doesn't conform to UPPER_CASE naming style (invalid-name)
libraries/dl-streamer/docs/scripts/models_table_from_yaml.py|17| C0103: Constant name "dlstreamer_name" doesn't conform to UPPER_CASE naming style (invalid-name)
libraries/dl-streamer/docs/scripts/models_table_from_yaml.py|41 col 5| W1514: Using open without explicitly specifying an encoding (unspecified-encoding)
libraries/dl-streamer/docs/scripts/models_table_from_yaml.py|56 col 4| W0105: String statement has no effect (pointless-string-statement)
libraries/dl-streamer/docs/scripts/models_table_from_yaml.py|108 col 16| C0209: Formatting a regular string which could be an f-string (consider-using-f-string)
libraries/dl-streamer/docs/scripts/models_table_from_yaml.py|109 col 16| C0209: Formatting a regular string which could be an f-string (consider-using-f-string)
libraries/dl-streamer/docs/scripts/models_table_from_yaml.py|110 col 16| C0209: Formatting a regular string which could be an f-string (consider-using-f-string)
libraries/dl-streamer/docs/scripts/models_table_from_yaml.py|122 col 20| C0209: Formatting a regular string which could be an f-string (consider-using-f-string)
libraries/dl-streamer/docs/scripts/models_table_from_yaml.py|129 col 24| C0209: Formatting a regular string which could be an f-string (consider-using-f-string)
libraries/dl-streamer/docs/scripts/models_table_from_yaml.py|131 col 24| C0209: Formatting a regular string which could be an f-string (consider-using-f-string)
libraries/dl-streamer/docs/scripts/models_table_from_yaml.py|146 col 20| C0209: Formatting a regular string which could be an f-string (consider-using-f-string)
libraries/dl-streamer/docs/scripts/models_yaml_from_zoo.py|85| C0301: Line too long (139/100) (line-too-long)
libraries/dl-streamer/docs/scripts/models_yaml_from_zoo.py|81 col 8| W0622: Redefining built-in 'format' (redefined-builtin)
libraries/dl-streamer/docs/scripts/models_yaml_from_zoo.py|21| C0103: Constant name "dldt_str" doesn't conform to UPPER_CASE naming style (invalid-name)
libraries/dl-streamer/docs/scripts/models_yaml_from_zoo.py|22| C0103: Constant name "openvino_str" doesn't conform to UPPER_CASE naming style (invalid-name)
libraries/dl-streamer/docs/scripts/models_yaml_from_zoo.py|23| C0103: Constant name "dlstreamer_name" doesn't conform to UPPER_CASE naming style (invalid-name)
libraries/dl-streamer/docs/scripts/models_yaml_from_zoo.py|56 col 13| W1514: Using open without explicitly specifying an encoding (unspecified-encoding)
libraries/dl-streamer/docs/scripts/models_yaml_from_zoo.py|59 col 13| W1514: Using open without explicitly specifying an encoding (unspecified-encoding)
libraries/dl-streamer/docs/scripts/models_yaml_from_zoo.py|66 col 13| W1514: Using open without explicitly specifying an encoding (unspecified-encoding)
libraries/dl-streamer/docs/scripts/models_yaml_from_zoo.py|155 col 13| W1514: Using open without explicitly specifying an encoding (unspecified-encoding)
libraries/dl-streamer/docs/scripts/models_yaml_from_zoo.py|167 col 46| R1733: Unnecessary dictionary index lookup, use 'm' instead (unnecessary-dict-index-lookup)
libraries/dl-streamer/docs/scripts/models_yaml_from_zoo.py|168 col 32| R1733: Unnecessary dictionary index lookup, use 'm' instead (unnecessary-dict-index-lookup)
libraries/dl-streamer/docs/scripts/models_yaml_from_zoo.py|170 col 32| R1733: Unnecessary dictionary index lookup, use 'm' instead (unnecessary-dict-index-lookup)
libraries/dl-streamer/docs/scripts/models_yaml_from_zoo.py|172 col 46| R1733: Unnecessary dictionary index lookup, use 'm' instead (unnecessary-dict-index-lookup)
libraries/dl-streamer/docs/scripts/models_yaml_from_zoo.py|173 col 32| R1733: Unnecessary dictionary index lookup, use 'm' instead (unnecessary-dict-index-lookup)
libraries/dl-streamer/docs/scripts/models_yaml_from_zoo.py|175 col 32| R1733: Unnecessary dictionary index lookup, use 'm' instead (unnecessary-dict-index-lookup)
libraries/dl-streamer/docs/scripts/models_yaml_from_zoo.py|274 col 5| W1514: Using open without explicitly specifying an encoding (unspecified-encoding)
libraries/dl-streamer/python/gstgva/region_of_interest.py|135 col 50| C0123: Use isinstance() rather than type() for a typecheck. (unidiomatic-typecheck)
libraries/dl-streamer/python/gstgva/region_of_interest.py|175 col 50| C0123: Use isinstance() rather than type() for a typecheck. (unidiomatic-typecheck)
libraries/dl-streamer/python/gstgva/tensor.py|392 col 4| C0116: Missing function or method docstring (missing-function-docstring)
libraries/dl-streamer/python/gstgva/util.py|254| W0212: Access to a protected member fields of a client class (protected-access)
libraries/dl-streamer/python/gstgva/util.py|400 col 8| W0212: Access to a protected member _message of a client class (protected-access)
libraries/dl-streamer/python/gstgva/video_frame.py|241 col 25| C0209: Formatting a regular string which could be an f-string (consider-using-f-string)
libraries/dl-streamer/python/gstgva/video_frame.py|291 col 16| C0209: Formatting a regular string which could be an f-string (consider-using-f-string)
libraries/dl-streamer/scripts/optimizer/optimizer.py|363| C0301: Line too long (112/100) (line-too-long)
libraries/dl-streamer/scripts/optimizer/optimizer.py|368| C0301: Line too long (131/100) (line-too-long)
libraries/dl-streamer/scripts/optimizer/optimizer.py|302| C0116: Missing function or method docstring (missing-function-docstring)
libraries/dl-streamer/src/gst/python/inference_openvino.py|108 col 19| C0209: Formatting a regular string which could be an f-string (consider-using-f-string)
libraries/dl-streamer/src/gst/python/inference_openvino.py|165 col 12| R1714: Consider merging these comparisons with 'in' by using 'event.type in (Gst.EventType.EOS, Gst.EventType.FLUSH_STOP)'. Use a set instead if elements are hashable. (consider-using-in)
libraries/dl-streamer/src/gst/python/python_object_association.py|63| C0301: Line too long (113/100) (line-too-long)
libraries/dl-streamer/src/gst/python/python_object_association.py|195| C0301: Line too long (112/100) (line-too-long)
libraries/dl-streamer/src/gst/python/python_object_association.py|195 col 20| W1309: Using an f-string that does not have any interpolated variables (f-string-without-interpolation)
libraries/dl-streamer/src/gst/python/python_object_association.py|143 col 8| W0201: Attribute '_object_class' defined outside init (attribute-defined-outside-init)
libraries/dl-streamer/src/gst/python/python_object_association.py|144 col 8| W0201: Attribute '_rewrite_roi' defined outside init (attribute-defined-outside-init)
libraries/dl-streamer/src/gst/python/python_object_association.py|145 col 8| W0201: Attribute '_save_label' defined outside init (attribute-defined-outside-init)
libraries/dl-streamer/src/gst/python/python_object_association.py|146 col 8| W0201: Attribute '_nn_budget' defined outside init (attribute-defined-outside-init)
libraries/dl-streamer/src/gst/python/python_object_association.py|147 col 8| W0201: Attribute '_max_iou_distance' defined outside init (attribute-defined-outside-init)
libraries/dl-streamer/src/gst/python/python_object_association.py|148 col 8| W0201: Attribute '_max_age' defined outside init (attribute-defined-outside-init)
libraries/dl-streamer/src/gst/python/python_object_association.py|149 col 8| W0201: Attribute '_n_init' defined outside init (attribute-defined-outside-init)
libraries/dl-streamer/src/gst/python/python_object_association.py|162 col 8| W0201: Attribute '__write_result' defined outside init (attribute-defined-outside-init)
libraries/dl-streamer/src/gst/python/pytorch_tensor_inference.py|128| C0301: Line too long (132/100) (line-too-long)
libraries/dl-streamer/src/gst/python/pytorch_tensor_inference.py|154| C0301: Line too long (161/100) (line-too-long)
libraries/dl-streamer/src/gst/python/pytorch_tensor_inference.py|161| C0301: Line too long (102/100) (line-too-long)
libraries/dl-streamer/src/gst/python/pytorch_tensor_inference.py|203| C0301: Line too long (162/100) (line-too-long)
libraries/dl-streamer/src/gst/python/pytorch_tensor_inference.py|227| C0301: Line too long (113/100) (line-too-long)
libraries/dl-streamer/src/gst/python/pytorch_tensor_inference.py|287| C0301: Line too long (127/100) (line-too-long)
libraries/dl-streamer/src/gst/python/pytorch_tensor_inference.py|334| C0301: Line too long (129/100) (line-too-long)
libraries/dl-streamer/src/gst/python/pytorch_tensor_inference.py|285 col 13| W0511: TODO: remove limitation. Support models with multiple inputs (fixme)
libraries/dl-streamer/src/gst/python/pytorch_tensor_inference.py|411 col 20| W0511: FIXME: support batching (fixme)
libraries/dl-streamer/src/gst/python/pytorch_tensor_inference.py|414 col 68| W0511: FIXME: support batching (fixme)
libraries/dl-streamer/src/gst/python/pytorch_tensor_inference.py|73 col 14| W0108: Lambda may not be necessary (unnecessary-lambda)
libraries/dl-streamer/src/gst/python/pytorch_tensor_inference.py|103 col 60| R1734: Consider using [] instead of list() (use-list-literal)
libraries/dl-streamer/src/gst/python/pytorch_tensor_inference.py|104 col 63| R1734: Consider using [] instead of list() (use-list-literal)
libraries/dl-streamer/tests/scripts/unit_test_results.py|49 col 9| W1514: Using open without explicitly specifying an encoding (unspecified-encoding)
libraries/dl-streamer/tests/unit_tests/tests_gstgva/pipeline_runner.py|69 col 4| W0221: Number of parameters was 2 in 'TestGenericPipelineRunner.set_pipeline' and is now 11 in overriding 'TestPipelineRunner.set_pipeline' method (arguments-differ)
libraries/dl-streamer/tests/unit_tests/tests_gstgva/pipeline_runner.py|69 col 4| R0913: Too many arguments (11/5) (too-many-arguments)
libraries/dl-streamer/tests/unit_tests/tests_gstgva/pipeline_runner.py|69 col 4| R0917: Too many positional arguments (11/5) (too-many-positional-arguments)
libraries/dl-streamer/tests/unit_tests/tests_gstgva/pipeline_runner.py|170 col 20| R1734: Consider using [] instead of list() (use-list-literal)
libraries/dl-streamer/tests/unit_tests/tests_gstgva/test_pipeline_color_formats.py|28 col 4| E0602: Undefined variable 'BBox' (undefined-variable)
libraries/dl-streamer/tests/unit_tests/tests_gstgva/test_pipeline_color_formats.py|36 col 4| E0602: Undefined variable 'BBox' (undefined-variable)
libraries/dl-streamer/tests/unit_tests/tests_gstgva/test_pipeline_color_formats.py|44 col 4| E0602: Undefined variable 'BBox' (undefined-variable)
libraries/dl-streamer/tests/unit_tests/tests_gstgva/test_pipeline_detection_yolo_11s.py|23 col 8| E0602: Undefined variable 'get_model_path' (undefined-variable)
libraries/dl-streamer/tests/unit_tests/tests_gstgva/test_pipeline_detection_yolo_11s.py|29 col 4| E0602: Undefined variable 'BBox' (undefined-variable)
libraries/dl-streamer/tests/unit_tests/tests_gstgva/test_pipeline_detection_yolo_11s.py|37 col 4| E0602: Undefined variable 'BBox' (undefined-variable)
libraries/dl-streamer/tests/unit_tests/tests_gstgva/test_pipeline_detection_yolo_11s.py|45 col 4| E0602: Undefined variable 'BBox' (undefined-variable)
libraries/dl-streamer/tests/unit_tests/tests_gstgva/test_pipeline_detection_yolo_11s.py|56 col 4| E0602: Undefined variable 'BBox' (undefined-variable)
libraries/dl-streamer/tests/unit_tests/tests_gstgva/test_pipeline_detection_yolo_11s.py|64 col 4| E0602: Undefined variable 'BBox' (undefined-variable)
libraries/dl-streamer/tests/unit_tests/tests_gstgva/test_pipeline_detection_yolo_11s.py|72 col 4| E0602: Undefined variable 'BBox' (undefined-variable)
libraries/dl-streamer/tests/unit_tests/tests_gstgva/test_pipeline_detection_yolo_v10s.py|30 col 4| E0602: Undefined variable 'BBox' (undefined-variable)
libraries/dl-streamer/tests/unit_tests/tests_gstgva/test_pipeline_detection_yolo_v10s.py|38 col 4| E0602: Undefined variable 'BBox' (undefined-variable)
libraries/dl-streamer/tests/unit_tests/tests_gstgva/test_pipeline_detection_yolo_v10s.py|46 col 4| E0602: Undefined variable 'BBox' (undefined-variable)
libraries/dl-streamer/tests/unit_tests/tests_gstgva/test_pipeline_face_detection_and_classification.py|60| C0325: Unnecessary parens after 'yield' keyword (superfluous-parens)
libraries/dl-streamer/tests/unit_tests/tests_gstgva/test_pipeline_face_detection_and_emotions-recognition-retail-0003.py|34 col 4| E0602: Undefined variable 'BBox' (undefined-variable)
libraries/dl-streamer/tests/unit_tests/tests_gstgva/test_pipeline_face_detection_and_emotions-recognition-retail-0003.py|42 col 4| E0602: Undefined variable 'BBox' (undefined-variable)
libraries/dl-streamer/tests/unit_tests/tests_gstgva/test_pipeline_gvainference_gvapython.py|29 col 13| E0602: Undefined variable 'BBox' (undefined-variable)
libraries/dl-streamer/tests/unit_tests/tests_gstgva/test_pipeline_gvainference_gvapython.py|29 col 31| E0602: Undefined variable 'BBox' (undefined-variable)
libraries/dl-streamer/tests/unit_tests/tests_gstgva/test_pipeline_gvapython_vaapi.py|38| C0301: Line too long (105/100) (line-too-long)
libraries/dl-streamer/tests/unit_tests/tests_gstgva/test_pipeline_vehicle_pedestrian_tracker.py|57| C0325: Unnecessary parens after 'yield' keyword (superfluous-parens)
libraries/dl-streamer/tests/unit_tests/tests_gstgva/test_tensor.py|77 col 44| C2801: Unnecessarily calls dunder method getitem. Access item via subscript. (unnecessary-dunder-call)
libraries/dl-streamer/tests/unit_tests/tests_gstgva/utils.py|47| C0301: Line too long (123/100) (line-too-long)
libraries/dl-streamer/tests/unit_tests/tests_gstgva/utils.py|163| C0301: Line too long (126/100) (line-too-long)
libraries/dl-streamer/tests/unit_tests/tests_gstgva/utils.py|33 col 33| C0209: Formatting a regular string which could be an f-string (consider-using-f-string)
libraries/dl-streamer/tests/unit_tests/tests_gstgva/utils.py|47 col 8| C0209: Formatting a regular string which could be an f-string (consider-using-f-string)
libraries/dl-streamer/tests/unit_tests/tests_gstgva/utils.py|75 col 4| R0913: Too many arguments (8/5) (too-many-arguments)
libraries/dl-streamer/tests/unit_tests/tests_gstgva/utils.py|75 col 4| R0917: Too many positional arguments (8/5) (too-many-positional-arguments)
libraries/dl-streamer/tests/unit_tests/tests_gstgva/utils.py|137 col 34| C0209: Formatting a regular string which could be an f-string (consider-using-f-string)
libraries/dl-streamer/tests/unit_tests/tests_gstgva/utils.py|144 col 34| C0209: Formatting a regular string which could be an f-string (consider-using-f-string)
libraries/dl-streamer/tests/unit_tests/tests_gstgva/utils.py|170 col 4| C0116: Missing function or method docstring (missing-function-docstring)
libraries/dl-streamer/tests/unit_tests/tests_gstgva/utils.py|179 col 16| C0209: Formatting a regular string which could be an f-string (consider-using-f-string)
libraries/dl-streamer/tests/unit_tests/tests_gstgva/utils.py|195 col 20| R1716: Simplify chained comparison between the operands (chained-comparison)
| elements = [] | ||
|
|
||
| result = subprocess.Popen(['gst-inspect-1.0', lib], stdout=subprocess.PIPE) | ||
| result = subprocess.Popen(["gst-inspect-1.0", lib], stdout=subprocess.PIPE) |
There was a problem hiding this comment.
[pylint] reported by reviewdog 🐶
R1732: Consider using 'with' for resource-allocating operations (consider-using-with)
| str = Gst.value_serialize(value) | ||
| return "{0:s} {1:15s}: {2:s}".format( | ||
| pfx, GLib.quark_to_string(field), str) | ||
| return "{0:s} {1:15s}: {2:s}".format(pfx, GLib.quark_to_string(field), str) |
There was a problem hiding this comment.
[pylint] reported by reviewdog 🐶
C0209: Formatting a regular string which could be an f-string (consider-using-f-string)
| str = Gst.value_serialize(value) | ||
| return "{0:s} {1:15s}: {2:s}".format( | ||
| pfx, GLib.quark_to_string(field), str) | ||
| return "{0:s} {1:15s}: {2:s}".format(pfx, GLib.quark_to_string(field), str) |
There was a problem hiding this comment.
[pylint] reported by reviewdog 🐶
E0602: Undefined variable 'GLib' (undefined-variable)
|
|
||
| def generate_table(table_data, table_header = ["", ""]): | ||
|
|
||
| def generate_table(table_data, table_header=["", ""]): |
There was a problem hiding this comment.
[pylint] reported by reviewdog 🐶
C0116: Missing function or method docstring (missing-function-docstring)
|
|
||
| def generate_table(table_data, table_header = ["", ""]): | ||
|
|
||
| def generate_table(table_data, table_header=["", ""]): |
There was a problem hiding this comment.
[pylint] reported by reviewdog 🐶
W0102: Dangerous default value [] as argument (dangerous-default-value)
| f.write(' - model-proc\n') | ||
| f.write(' - OpenVINO™ Open Model Zoo demo app\n') | ||
| f.write('\n') | ||
| with open(args.output, "w") as f: |
There was a problem hiding this comment.
[pylint] reported by reviewdog 🐶
W1514: Using open without explicitly specifying an encoding (unspecified-encoding)
| f.write("\n") | ||
| f.write(" * - Abbreviation\n") | ||
| f.write(" - Description\n") | ||
| f.write(" * - {0}\n".format(openvino_str)) |
There was a problem hiding this comment.
[pylint] reported by reviewdog 🐶
C0209: Formatting a regular string which could be an f-string (consider-using-f-string)
| f.write(" - Description\n") | ||
| f.write(" * - {0}\n".format(openvino_str)) | ||
| f.write( | ||
| " - `OpenVINO™ toolkit <https://docs.openvino.ai/>`__ - as model file format (*.xml + *.bin) and inference backend in {0}\n".format( |
There was a problem hiding this comment.
[pylint] reported by reviewdog 🐶
C0209: Formatting a regular string which could be an f-string (consider-using-f-string)
| ) | ||
| f.write(" * - pytorch\n") | ||
| f.write( | ||
| " - `PyTorch* framework <https://pytorch.org>`__ - as model file format and inference backend in {0}\n".format( |
There was a problem hiding this comment.
[pylint] reported by reviewdog 🐶
C0209: Formatting a regular string which could be an f-string (consider-using-f-string)
| ) | ||
| f.write(" * - tf\n") | ||
| f.write( | ||
| " - `TensorFlow* framework <https://www.tensorflow.org>`__ - as model file format and inference backend in {0}\n".format( |
There was a problem hiding this comment.
[pylint] reported by reviewdog 🐶
C0209: Formatting a regular string which could be an f-string (consider-using-f-string)
There was a problem hiding this comment.
Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit
pylint
libraries/dl-streamer/src/gst/python/python_object_association.py|195 col 20| W1309: Using an f-string that does not have any interpolated variables (f-string-without-interpolation)
libraries/dl-streamer/src/gst/python/python_object_association.py|143 col 8| W0201: Attribute '_object_class' defined outside init (attribute-defined-outside-init)
libraries/dl-streamer/src/gst/python/python_object_association.py|144 col 8| W0201: Attribute '_rewrite_roi' defined outside init (attribute-defined-outside-init)
libraries/dl-streamer/src/gst/python/python_object_association.py|145 col 8| W0201: Attribute '_save_label' defined outside init (attribute-defined-outside-init)
libraries/dl-streamer/src/gst/python/python_object_association.py|146 col 8| W0201: Attribute '_nn_budget' defined outside init (attribute-defined-outside-init)
libraries/dl-streamer/src/gst/python/python_object_association.py|147 col 8| W0201: Attribute '_max_iou_distance' defined outside init (attribute-defined-outside-init)
libraries/dl-streamer/src/gst/python/python_object_association.py|148 col 8| W0201: Attribute '_max_age' defined outside init (attribute-defined-outside-init)
libraries/dl-streamer/src/gst/python/python_object_association.py|149 col 8| W0201: Attribute '_n_init' defined outside init (attribute-defined-outside-init)
libraries/dl-streamer/src/gst/python/python_object_association.py|162 col 8| W0201: Attribute '__write_result' defined outside init (attribute-defined-outside-init)
libraries/dl-streamer/src/gst/python/pytorch_tensor_inference.py|128| C0301: Line too long (132/100) (line-too-long)
libraries/dl-streamer/src/gst/python/pytorch_tensor_inference.py|154| C0301: Line too long (161/100) (line-too-long)
libraries/dl-streamer/src/gst/python/pytorch_tensor_inference.py|161| C0301: Line too long (102/100) (line-too-long)
libraries/dl-streamer/src/gst/python/pytorch_tensor_inference.py|203| C0301: Line too long (162/100) (line-too-long)
libraries/dl-streamer/src/gst/python/pytorch_tensor_inference.py|227| C0301: Line too long (113/100) (line-too-long)
libraries/dl-streamer/src/gst/python/pytorch_tensor_inference.py|287| C0301: Line too long (127/100) (line-too-long)
libraries/dl-streamer/src/gst/python/pytorch_tensor_inference.py|334| C0301: Line too long (129/100) (line-too-long)
libraries/dl-streamer/src/gst/python/pytorch_tensor_inference.py|285 col 13| W0511: TODO: remove limitation. Support models with multiple inputs (fixme)
libraries/dl-streamer/src/gst/python/pytorch_tensor_inference.py|411 col 20| W0511: FIXME: support batching (fixme)
libraries/dl-streamer/src/gst/python/pytorch_tensor_inference.py|414 col 68| W0511: FIXME: support batching (fixme)
libraries/dl-streamer/src/gst/python/pytorch_tensor_inference.py|73 col 14| W0108: Lambda may not be necessary (unnecessary-lambda)
libraries/dl-streamer/src/gst/python/pytorch_tensor_inference.py|103 col 60| R1734: Consider using [] instead of list() (use-list-literal)
libraries/dl-streamer/src/gst/python/pytorch_tensor_inference.py|104 col 63| R1734: Consider using [] instead of list() (use-list-literal)
libraries/dl-streamer/tests/scripts/unit_test_results.py|49 col 9| W1514: Using open without explicitly specifying an encoding (unspecified-encoding)
libraries/dl-streamer/tests/unit_tests/tests_gstgva/pipeline_runner.py|69 col 4| W0221: Number of parameters was 2 in 'TestGenericPipelineRunner.set_pipeline' and is now 11 in overriding 'TestPipelineRunner.set_pipeline' method (arguments-differ)
libraries/dl-streamer/tests/unit_tests/tests_gstgva/pipeline_runner.py|69 col 4| R0913: Too many arguments (11/5) (too-many-arguments)
libraries/dl-streamer/tests/unit_tests/tests_gstgva/pipeline_runner.py|69 col 4| R0917: Too many positional arguments (11/5) (too-many-positional-arguments)
libraries/dl-streamer/tests/unit_tests/tests_gstgva/pipeline_runner.py|170 col 20| R1734: Consider using [] instead of list() (use-list-literal)
libraries/dl-streamer/tests/unit_tests/tests_gstgva/test_pipeline_color_formats.py|28 col 4| E0602: Undefined variable 'BBox' (undefined-variable)
libraries/dl-streamer/tests/unit_tests/tests_gstgva/test_pipeline_color_formats.py|36 col 4| E0602: Undefined variable 'BBox' (undefined-variable)
libraries/dl-streamer/tests/unit_tests/tests_gstgva/test_pipeline_color_formats.py|44 col 4| E0602: Undefined variable 'BBox' (undefined-variable)
libraries/dl-streamer/tests/unit_tests/tests_gstgva/test_pipeline_detection_yolo_11s.py|23 col 8| E0602: Undefined variable 'get_model_path' (undefined-variable)
libraries/dl-streamer/tests/unit_tests/tests_gstgva/test_pipeline_detection_yolo_11s.py|29 col 4| E0602: Undefined variable 'BBox' (undefined-variable)
libraries/dl-streamer/tests/unit_tests/tests_gstgva/test_pipeline_detection_yolo_11s.py|37 col 4| E0602: Undefined variable 'BBox' (undefined-variable)
libraries/dl-streamer/tests/unit_tests/tests_gstgva/test_pipeline_detection_yolo_11s.py|45 col 4| E0602: Undefined variable 'BBox' (undefined-variable)
libraries/dl-streamer/tests/unit_tests/tests_gstgva/test_pipeline_detection_yolo_11s.py|56 col 4| E0602: Undefined variable 'BBox' (undefined-variable)
libraries/dl-streamer/tests/unit_tests/tests_gstgva/test_pipeline_detection_yolo_11s.py|64 col 4| E0602: Undefined variable 'BBox' (undefined-variable)
libraries/dl-streamer/tests/unit_tests/tests_gstgva/test_pipeline_detection_yolo_11s.py|72 col 4| E0602: Undefined variable 'BBox' (undefined-variable)
libraries/dl-streamer/tests/unit_tests/tests_gstgva/test_pipeline_detection_yolo_v10s.py|30 col 4| E0602: Undefined variable 'BBox' (undefined-variable)
libraries/dl-streamer/tests/unit_tests/tests_gstgva/test_pipeline_detection_yolo_v10s.py|38 col 4| E0602: Undefined variable 'BBox' (undefined-variable)
libraries/dl-streamer/tests/unit_tests/tests_gstgva/test_pipeline_detection_yolo_v10s.py|46 col 4| E0602: Undefined variable 'BBox' (undefined-variable)
libraries/dl-streamer/tests/unit_tests/tests_gstgva/test_pipeline_face_detection_and_classification.py|60| C0325: Unnecessary parens after 'yield' keyword (superfluous-parens)
libraries/dl-streamer/tests/unit_tests/tests_gstgva/test_pipeline_face_detection_and_emotions-recognition-retail-0003.py|34 col 4| E0602: Undefined variable 'BBox' (undefined-variable)
libraries/dl-streamer/tests/unit_tests/tests_gstgva/test_pipeline_face_detection_and_emotions-recognition-retail-0003.py|42 col 4| E0602: Undefined variable 'BBox' (undefined-variable)
libraries/dl-streamer/tests/unit_tests/tests_gstgva/test_pipeline_gvainference_gvapython.py|29 col 13| E0602: Undefined variable 'BBox' (undefined-variable)
libraries/dl-streamer/tests/unit_tests/tests_gstgva/test_pipeline_gvainference_gvapython.py|29 col 31| E0602: Undefined variable 'BBox' (undefined-variable)
libraries/dl-streamer/tests/unit_tests/tests_gstgva/test_pipeline_gvapython_vaapi.py|38| C0301: Line too long (105/100) (line-too-long)
libraries/dl-streamer/tests/unit_tests/tests_gstgva/test_pipeline_vehicle_pedestrian_tracker.py|57| C0325: Unnecessary parens after 'yield' keyword (superfluous-parens)
libraries/dl-streamer/tests/unit_tests/tests_gstgva/test_tensor.py|77 col 44| C2801: Unnecessarily calls dunder method getitem. Access item via subscript. (unnecessary-dunder-call)
libraries/dl-streamer/tests/unit_tests/tests_gstgva/utils.py|47| C0301: Line too long (123/100) (line-too-long)
libraries/dl-streamer/tests/unit_tests/tests_gstgva/utils.py|163| C0301: Line too long (126/100) (line-too-long)
libraries/dl-streamer/tests/unit_tests/tests_gstgva/utils.py|33 col 33| C0209: Formatting a regular string which could be an f-string (consider-using-f-string)
libraries/dl-streamer/tests/unit_tests/tests_gstgva/utils.py|47 col 8| C0209: Formatting a regular string which could be an f-string (consider-using-f-string)
libraries/dl-streamer/tests/unit_tests/tests_gstgva/utils.py|75 col 4| R0913: Too many arguments (8/5) (too-many-arguments)
libraries/dl-streamer/tests/unit_tests/tests_gstgva/utils.py|75 col 4| R0917: Too many positional arguments (8/5) (too-many-positional-arguments)
libraries/dl-streamer/tests/unit_tests/tests_gstgva/utils.py|137 col 34| C0209: Formatting a regular string which could be an f-string (consider-using-f-string)
libraries/dl-streamer/tests/unit_tests/tests_gstgva/utils.py|144 col 34| C0209: Formatting a regular string which could be an f-string (consider-using-f-string)
libraries/dl-streamer/tests/unit_tests/tests_gstgva/utils.py|170 col 4| C0116: Missing function or method docstring (missing-function-docstring)
libraries/dl-streamer/tests/unit_tests/tests_gstgva/utils.py|179 col 16| C0209: Formatting a regular string which could be an f-string (consider-using-f-string)
libraries/dl-streamer/tests/unit_tests/tests_gstgva/utils.py|195 col 20| R1716: Simplify chained comparison between the operands (chained-comparison)
|
|
||
| format += ", " + openvino_str | ||
| models[name]["format"] = format | ||
| # models[name]['readme'] = 'https://docs.openvino.ai/latest/omz_models_model_' + name.replace('-', '_').replace('.', '_') + '.html' |
There was a problem hiding this comment.
[pylint] reported by reviewdog 🐶
C0301: Line too long (139/100) (line-too-long)
| models[name]["source"] = "intel" # openvino_str | ||
| elif "models/public/" in root: | ||
| models[name]["source"] = "public" | ||
| format = models[name].get("framework", "").replace(dldt_str, openvino_str) |
There was a problem hiding this comment.
[pylint] reported by reviewdog 🐶
W0622: Redefining built-in 'format' (redefined-builtin)
| dldt_str = 'dl' + 'dt' | ||
| openvino_str = 'open' + 'vino' | ||
| dlstreamer_name = 'Deep ' + 'Learning' + ' Streamer' | ||
| dldt_str = "dl" + "dt" |
There was a problem hiding this comment.
[pylint] reported by reviewdog 🐶
C0103: Constant name "dldt_str" doesn't conform to UPPER_CASE naming style (invalid-name)
| openvino_str = 'open' + 'vino' | ||
| dlstreamer_name = 'Deep ' + 'Learning' + ' Streamer' | ||
| dldt_str = "dl" + "dt" | ||
| openvino_str = "open" + "vino" |
There was a problem hiding this comment.
[pylint] reported by reviewdog 🐶
C0103: Constant name "openvino_str" doesn't conform to UPPER_CASE naming style (invalid-name)
| dlstreamer_name = 'Deep ' + 'Learning' + ' Streamer' | ||
| dldt_str = "dl" + "dt" | ||
| openvino_str = "open" + "vino" | ||
| dlstreamer_name = "Deep " + "Learning" + " Streamer" |
There was a problem hiding this comment.
[pylint] reported by reviewdog 🐶
C0103: Constant name "dlstreamer_name" doesn't conform to UPPER_CASE naming style (invalid-name)
| # 6. Any time a better pipeline is found, save it and its performance information. | ||
| # 7. Return the best discovered pipeline. | ||
| def get_optimized_pipeline(pipeline, search_duration = 300, sample_duration = 10): | ||
| def get_optimized_pipeline(pipeline, search_duration=300, sample_duration=10): |
There was a problem hiding this comment.
[pylint] reported by reviewdog 🐶
C0116: Missing function or method docstring (missing-function-docstring)
| ":".join(str(d) for d in np.array(info.shape)[::-1]) for info in infos | ||
| ] # dims in reverse order | ||
| types = [self.TYPE_NAME[info.element_type.get_type_name()] for info in infos] | ||
| caps_str = "other/tensors,num_tensors=(uint){num},types={types},dimensions={shapes}".format( |
There was a problem hiding this comment.
[pylint] reported by reviewdog 🐶
C0209: Formatting a regular string which could be an f-string (consider-using-f-string)
| def do_sink_event(self, event): | ||
| if (event.type == Gst.EventType.EOS or event.type == Gst.EventType.FLUSH_STOP) and self.infer_queue: | ||
| if ( | ||
| event.type == Gst.EventType.EOS or event.type == Gst.EventType.FLUSH_STOP |
There was a problem hiding this comment.
[pylint] reported by reviewdog 🐶
R1714: Consider merging these comparisons with 'in' by using 'event.type in (Gst.EventType.EOS, Gst.EventType.FLUSH_STOP)'. Use a set instead if elements are hashable. (consider-using-in)
| __gstmetadata__ = ( | ||
| "ID assignment tracking algorithm", | ||
| "Transform", | ||
| "ID assignment SORT type tracking algorithm which require embedding from each ROI to cosine comparison.", |
There was a problem hiding this comment.
[pylint] reported by reviewdog 🐶
C0301: Line too long (113/100) (line-too-long)
| # TODO: create special label for embedding | ||
| Gst.warning( | ||
| f"Limitation: must be only 1 tensor meta per ROI which is embedding, except detection meta.") | ||
| f"Limitation: must be only 1 tensor meta per ROI which is embedding, except detection meta." |
There was a problem hiding this comment.
[pylint] reported by reviewdog 🐶
C0301: Line too long (112/100) (line-too-long)
There was a problem hiding this comment.
Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit
pylint
libraries/dl-streamer/tests/unit_tests/tests_gstgva/test_pipeline_detection_yolo_11s.py|72 col 4| E0602: Undefined variable 'BBox' (undefined-variable)
libraries/dl-streamer/tests/unit_tests/tests_gstgva/test_pipeline_detection_yolo_v10s.py|30 col 4| E0602: Undefined variable 'BBox' (undefined-variable)
libraries/dl-streamer/tests/unit_tests/tests_gstgva/test_pipeline_detection_yolo_v10s.py|38 col 4| E0602: Undefined variable 'BBox' (undefined-variable)
libraries/dl-streamer/tests/unit_tests/tests_gstgva/test_pipeline_detection_yolo_v10s.py|46 col 4| E0602: Undefined variable 'BBox' (undefined-variable)
libraries/dl-streamer/tests/unit_tests/tests_gstgva/test_pipeline_face_detection_and_emotions-recognition-retail-0003.py|34 col 4| E0602: Undefined variable 'BBox' (undefined-variable)
libraries/dl-streamer/tests/unit_tests/tests_gstgva/test_pipeline_face_detection_and_emotions-recognition-retail-0003.py|42 col 4| E0602: Undefined variable 'BBox' (undefined-variable)
libraries/dl-streamer/tests/unit_tests/tests_gstgva/test_pipeline_gvainference_gvapython.py|29 col 13| E0602: Undefined variable 'BBox' (undefined-variable)
libraries/dl-streamer/tests/unit_tests/tests_gstgva/test_pipeline_gvainference_gvapython.py|29 col 31| E0602: Undefined variable 'BBox' (undefined-variable)
libraries/dl-streamer/tests/unit_tests/tests_gstgva/test_tensor.py|77 col 44| C2801: Unnecessarily calls dunder method getitem. Access item via subscript. (unnecessary-dunder-call)
libraries/dl-streamer/tests/unit_tests/tests_gstgva/utils.py|75 col 4| R0913: Too many arguments (8/5) (too-many-arguments)
libraries/dl-streamer/tests/unit_tests/tests_gstgva/utils.py|75 col 4| R0917: Too many positional arguments (8/5) (too-many-positional-arguments)
libraries/dl-streamer/tests/unit_tests/tests_gstgva/utils.py|171 col 4| C0116: Missing function or method docstring (missing-function-docstring)
| # TODO: create special label for embedding | ||
| Gst.warning( | ||
| f"Limitation: must be only 1 tensor meta per ROI which is embedding, except detection meta.") | ||
| "Limitation: must be only 1 tensor meta per ROI which is embedding, except detection meta." |
There was a problem hiding this comment.
[pylint] reported by reviewdog 🐶
C0301: Line too long (111/100) (line-too-long)
| ) | ||
|
|
||
| self.__write_result = self.__rewrite_regions_with_tracks if self._rewrite_roi else self.__write_ids_to_regions | ||
| self.__write_result = ( |
There was a problem hiding this comment.
[pylint] reported by reviewdog 🐶
W0201: Attribute '__write_result' defined outside init (attribute-defined-outside-init)
| return list() | ||
|
|
||
| res = map(lambda x: int(x), arr.split(':')) | ||
| res = map(lambda x: int(x), arr.split(":")) |
There was a problem hiding this comment.
[pylint] reported by reviewdog 🐶
W0108: Lambda may not be necessary (unnecessary-lambda)
| if len(model_name_arr) < 2: | ||
| raise AttributeError( | ||
| f"Invalid module name in property 'model'. It must include at least the name of the import module and the name of the model. Got: {model_str}") | ||
| f"Invalid module name in property 'model'. It must include at least " + |
There was a problem hiding this comment.
[pylint] reported by reviewdog 🐶
W1309: Using an f-string that does not have any interpolated variables (f-string-without-interpolation)
| class TestGenericPipelineRunner(unittest.TestCase): | ||
| def set_pipeline(self, pipeline): | ||
| def set_pipeline( | ||
| self, |
There was a problem hiding this comment.
[pylint] reported by reviewdog 🐶
C0303: Trailing whitespace (trailing-whitespace)
| 0.8919420810698284, 0.2956839696427691, [], class_id=7), | ||
| BBox(0.1501398097734139, 0.21889342922873212, | ||
| 0.7452847887655665, 0.7433104570456628, [], class_id=1) | ||
| BBox( |
There was a problem hiding this comment.
[pylint] reported by reviewdog 🐶
E0602: Undefined variable 'BBox' (undefined-variable)
| [], | ||
| class_id=16, | ||
| ), | ||
| BBox( |
There was a problem hiding this comment.
[pylint] reported by reviewdog 🐶
E0602: Undefined variable 'BBox' (undefined-variable)
| [], | ||
| class_id=7, | ||
| ), | ||
| BBox( |
There was a problem hiding this comment.
[pylint] reported by reviewdog 🐶
E0602: Undefined variable 'BBox' (undefined-variable)
| 0.7408722987901015, 0.728528415091759, [], class_id=1), | ||
| BBox(0.6058582396188115, 0.12965262129385202, | ||
| 0.9041038647905566, 0.2973447724781151, [], class_id=2) | ||
| BBox( |
There was a problem hiding this comment.
[pylint] reported by reviewdog 🐶
E0602: Undefined variable 'BBox' (undefined-variable)
| [], | ||
| class_id=16, | ||
| ), | ||
| BBox( |
There was a problem hiding this comment.
[pylint] reported by reviewdog 🐶
E0602: Undefined variable 'BBox' (undefined-variable)
| [], | ||
| class_id=1, | ||
| ), | ||
| BBox( |
There was a problem hiding this comment.
[pylint] reported by reviewdog 🐶
E0602: Undefined variable 'BBox' (undefined-variable)
| 0.8919420810698284, 0.2956839696427691, [], class_id=7), | ||
| BBox(0.1501398097734139, 0.21889342922873212, | ||
| 0.7452847887655665, 0.7433104570456628, [], class_id=1) | ||
| BBox( |
There was a problem hiding this comment.
[pylint] reported by reviewdog 🐶
E0602: Undefined variable 'BBox' (undefined-variable)
| [], | ||
| class_id=16, | ||
| ), | ||
| BBox( |
There was a problem hiding this comment.
[pylint] reported by reviewdog 🐶
E0602: Undefined variable 'BBox' (undefined-variable)
| [], | ||
| class_id=7, | ||
| ), | ||
| BBox( |
There was a problem hiding this comment.
[pylint] reported by reviewdog 🐶
E0602: Undefined variable 'BBox' (undefined-variable)
| } | ||
| ], class_id=0 | ||
| ) | ||
| BBox( |
There was a problem hiding this comment.
[pylint] reported by reviewdog 🐶
E0602: Undefined variable 'BBox' (undefined-variable)
| BBox(0, 0, 1, 1), | ||
| BBox(0, 0, 1, 1) | ||
| ] | ||
| GOLD_TRUE = [BBox(0, 0, 1, 1), BBox(0, 0, 1, 1)] |
There was a problem hiding this comment.
[pylint] reported by reviewdog 🐶
E0602: Undefined variable 'BBox' (undefined-variable)
| self.assertEqual(tensor.has_field("precision"), True) | ||
| self.assertEqual((Tensor.PRECISION)( | ||
| tensor.__getitem__("precision")), tensor.precision()) | ||
| self.assertEqual((Tensor.PRECISION)(tensor.__getitem__("precision")), tensor.precision()) |
There was a problem hiding this comment.
[pylint] reported by reviewdog 🐶
C2801: Unnecessarily calls dunder method getitem. Access item via subscript. (unnecessary-dunder-call)
|
|
||
| class BBox: | ||
| def __init__(self, x_min, y_min, x_max, y_max, additional_info=None, class_id=0, tracker_id=None): | ||
| def __init__( |
There was a problem hiding this comment.
[pylint] reported by reviewdog 🐶
R0913: Too many arguments (8/5) (too-many-arguments)
|
|
||
| class BBox: | ||
| def __init__(self, x_min, y_min, x_max, y_max, additional_info=None, class_id=0, tracker_id=None): | ||
| def __init__( |
There was a problem hiding this comment.
[pylint] reported by reviewdog 🐶
R0917: Too many positional arguments (8/5) (too-many-positional-arguments)
| @ staticmethod | ||
| def bboxes_is_equal(pr_bboxes: list, gt_bboxes: list, only_number=False, check_additional_info=True): | ||
| @staticmethod | ||
| def bboxes_is_equal( |
There was a problem hiding this comment.
[pylint] reported by reviewdog 🐶
C0116: Missing function or method docstring (missing-function-docstring)
| m["task_type"] = "detection" | ||
| if "task_type" not in m: | ||
| m["task_type"] = "~?" | ||
| format = m.get("format", "") |
There was a problem hiding this comment.
[pylint] reported by reviewdog 🐶
W0622: Redefining built-in 'format' (redefined-builtin)
|
|
||
| def __repr__(self) -> str: | ||
| return f"{self.top_left_x}, {self.top_left_y}, {self.bottom_right_x}, {self.bottom_right_y}, {self.confidence}" | ||
| return (f"{self.top_left_x}, {self.top_left_y}, {self.bottom_right_x}, " + |
There was a problem hiding this comment.
[pylint] reported by reviewdog 🐶
E0001: Parsing failed: ''(' was never closed (instance_segmentation_0002_postproc, line 115)' (syntax-error)
|
|
||
| def __str__(self): | ||
| return f"<({self.x_min}, {self.y_min}, {self.x_max}, {self.y_max}), {self.additional_info}, class_id={self.class_id}, tracker_id={self.tracker_id}>" | ||
| return (f"<({self.x_min}, {self.y_min}, {self.x_max}, {self.y_max}), " + |
There was a problem hiding this comment.
[pylint] reported by reviewdog 🐶
E0001: Parsing failed: ''(' was never closed (tests_gstgva.utils, line 87)' (syntax-error)
| from .util import libgst, libgobject, libgstvideo, GLIST_POINTER | ||
|
|
||
| import gi | ||
| from gi.repository import GstVideo, GLib, GObject, Gst, GstAnalytics |
There was a problem hiding this comment.
[pylint] reported by reviewdog 🐶
E0401: Unable to import 'gi.repository' (import-error)
| from .util import libgst, libgobject, libgstvideo, GLIST_POINTER | ||
|
|
||
| import gi | ||
| from gi.repository import GstVideo, GLib, GObject, Gst, GstAnalytics |
There was a problem hiding this comment.
[pylint] reported by reviewdog 🐶
C0411: third party import "gi.repository.GstVideo" should be placed before local imports "tensor.Tensor", "util.VideoRegionOfInterestMeta", "util.libgst" (wrong-import-order)
| from .util import libgst, libgobject, libgstvideo, GLIST_POINTER | ||
|
|
||
| import gi | ||
| from gi.repository import GstVideo, GLib, GObject, Gst, GstAnalytics |
There was a problem hiding this comment.
[pylint] reported by reviewdog 🐶
W0611: Unused GstVideo imported from gi.repository (unused-import)
| from .util import libgst, libgobject, libgstvideo, GLIST_POINTER | ||
|
|
||
| import gi | ||
| from gi.repository import GstVideo, GLib, GObject, Gst, GstAnalytics |
There was a problem hiding this comment.
[pylint] reported by reviewdog 🐶
W0611: Unused GObject imported from gi.repository (unused-import)
| return input_tensors_info | ||
|
|
||
| # TODO: Parse the remaining preprocessing information and pass it to the preprocessing sub-pipeline | ||
| # TODO: Parse the remaining preprocessing information and pass it to |
There was a problem hiding this comment.
[pylint] reported by reviewdog 🐶
W0511: TODO: Parse the remaining preprocessing information and pass it to (fixme)
| regions.append(bbox) | ||
| for tensor in frame.tensors(): | ||
| # TODO: add 'is_classification' check for the Tensor using the 'type' field of this tensor | ||
| # TODO: add 'is_classification' check for the Tensor using |
There was a problem hiding this comment.
[pylint] reported by reviewdog 🐶
W0511: TODO: add 'is_classification' check for the Tensor using (fixme)
| from typing import List | ||
| from collections import namedtuple | ||
|
|
||
| from gi.repository import GstVideo, GLib, GObject, Gst, GstAnalytics |
There was a problem hiding this comment.
[pylint] reported by reviewdog 🐶
E0401: Unable to import 'gi.repository' (import-error)
| from typing import List | ||
| from collections import namedtuple | ||
|
|
||
| from gi.repository import GstVideo, GLib, GObject, Gst, GstAnalytics |
There was a problem hiding this comment.
[pylint] reported by reviewdog 🐶
W0611: Unused GstVideo imported from gi.repository (unused-import)
| from typing import List | ||
| from collections import namedtuple | ||
|
|
||
| from gi.repository import GstVideo, GLib, GObject, Gst, GstAnalytics |
There was a problem hiding this comment.
[pylint] reported by reviewdog 🐶
W0611: Unused GObject imported from gi.repository (unused-import)
| def set_pipeline(self, pipeline, image_path, ground_truth, | ||
| check_only_bbox_number=False, check_additional_info=True, check_frame_data=True, | ||
| ground_truth_per_frame=False, image_repeat_num=7, check_first_skip=0, check_format=True): | ||
| def set_pipeline( |
There was a problem hiding this comment.
[pylint] reported by reviewdog 🐶
W0221: Number of parameters was 2 in 'TestGenericPipelineRunner.set_pipeline' and is now 11 in overriding 'TestPipelineRunner.set_pipeline' method (arguments-differ)
| from typing import List | ||
| from collections import namedtuple | ||
| import ctypes | ||
| import numpy |
There was a problem hiding this comment.
[pylint] reported by reviewdog 🐶
E0401: Unable to import 'numpy' (import-error)
| from collections import namedtuple | ||
| import ctypes | ||
| import numpy | ||
| import gi |
There was a problem hiding this comment.
[pylint] reported by reviewdog 🐶
E0401: Unable to import 'gi' (import-error)
| from typing import List | ||
| from collections import namedtuple | ||
| import ctypes | ||
| import numpy |
There was a problem hiding this comment.
[pylint] reported by reviewdog 🐶
W0611: Unused import numpy (unused-import)
| return self["label"] | ||
| else: | ||
| raise RuntimeError("Detection GVA::Tensor can't have label.") | ||
| return self["label"] |
There was a problem hiding this comment.
[pylint] reported by reviewdog 🐶
C0303: Trailing whitespace (trailing-whitespace)
| # Fallback return value | ||
| libgst.g_value_array_free(gvalue_array) | ||
| return libgst.gst_structure_get_value(self.__structure, key) | ||
|
|
There was a problem hiding this comment.
[pylint] reported by reviewdog 🐶
C0303: Trailing whitespace (trailing-whitespace)
| from enum import Enum | ||
| import ctypes | ||
| import numpy | ||
| import gi |
There was a problem hiding this comment.
[pylint] reported by reviewdog 🐶
E0401: Unable to import 'gi' (import-error)
| hash(buffer), ctypes.byref(gpointer), meta_api | ||
| ) | ||
| except Exception as error: | ||
| except Exception: |
There was a problem hiding this comment.
[pylint] reported by reviewdog 🐶
W0718: Catching too general exception Exception (broad-exception-caught)
| tensor_meta_info = libgst.gst_meta_get_info("GstGVATensorMeta".encode("utf-8")) | ||
| value = libgst.gst_buffer_add_meta(hash(buffer), tensor_meta_info, None) | ||
| except Exception as error: | ||
| except Exception: |
There was a problem hiding this comment.
[pylint] reported by reviewdog 🐶
W0718: Catching too general exception Exception (broad-exception-caught)
| json_meta_info = libgst.gst_meta_get_info("GstGVAJSONMeta".encode("utf-8")) | ||
| value = libgst.gst_buffer_add_meta(hash(buffer), json_meta_info, None) | ||
| except Exception as error: | ||
| except Exception: |
There was a problem hiding this comment.
[pylint] reported by reviewdog 🐶
W0718: Catching too general exception Exception (broad-exception-caught)
| except Exception as error: | ||
| hash(buffer), ctypes.byref(gpointer), meta_api | ||
| ) | ||
| except Exception: |
There was a problem hiding this comment.
[pylint] reported by reviewdog 🐶
W0718: Catching too general exception Exception (broad-exception-caught)
| from collections import namedtuple | ||
|
|
||
| import ctypes | ||
| import numpy |
There was a problem hiding this comment.
[pylint] reported by reviewdog 🐶
E0401: Unable to import 'numpy' (import-error)
|
|
||
| import ctypes | ||
| import numpy | ||
| import gi |
There was a problem hiding this comment.
[pylint] reported by reviewdog 🐶
E0401: Unable to import 'gi' (import-error)
| import ctypes | ||
| import numpy | ||
| import gi | ||
| from gi.repository import GstAudio, GLib, GObject, Gst |
There was a problem hiding this comment.
[pylint] reported by reviewdog 🐶
E0401: Unable to import 'gi.repository' (import-error)
| from collections import namedtuple | ||
|
|
||
| import ctypes | ||
| import numpy |
There was a problem hiding this comment.
[pylint] reported by reviewdog 🐶
W0611: Unused import numpy (unused-import)
| import ctypes | ||
| import numpy | ||
| import gi | ||
| from gi.repository import GstAudio, GLib, GObject, Gst |
There was a problem hiding this comment.
[pylint] reported by reviewdog 🐶
W0611: Unused GstAudio imported from gi.repository (unused-import)
| from warnings import warn | ||
|
|
||
| import ctypes | ||
| import numpy |
There was a problem hiding this comment.
[pylint] reported by reviewdog 🐶
E0401: Unable to import 'numpy' (import-error)
| from warnings import warn | ||
| import json | ||
| import ctypes | ||
| import numpy |
There was a problem hiding this comment.
[pylint] reported by reviewdog 🐶
E0401: Unable to import 'numpy' (import-error)
| if res[0] and 0 <= label_id < res[1].n_values: | ||
| return res[1].get_nth(label_id) | ||
| return "" | ||
| return "" |
There was a problem hiding this comment.
[pylint] reported by reviewdog 🐶
C0304: Final newline missing (missing-final-newline)
| from gi.repository import GstVideo, GLib, GObject, Gst, GstAnalytics | ||
| from .tensor import Tensor | ||
| from .util import VideoRegionOfInterestMeta | ||
| from .util import libgst, libgobject, libgstvideo, GLIST_POINTER |
There was a problem hiding this comment.
[pylint] reported by reviewdog 🐶
W0611: Unused libgobject imported from util (unused-import)
| from gi.repository import GstVideo, GLib, GObject, Gst, GstAnalytics | ||
| from .tensor import Tensor | ||
| from .util import VideoRegionOfInterestMeta | ||
| from .util import libgst, libgobject, libgstvideo, GLIST_POINTER |
There was a problem hiding this comment.
[pylint] reported by reviewdog 🐶
W0611: Unused GLIST_POINTER imported from util (unused-import)
marcin-wadolkowski
changed the title
Description
Please include a summary of the changes and the related issue. List any dependencies that are required for this change.
Fixes # (issue)
Any Newly Introduced Dependencies
Please describe any newly introduced 3rd party dependencies in this change. List their name, license information and how they are used in the project.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist: