Skip to content

[Model Download] Fix failing unit test cases #1529

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
madhuri-rai07 merged 2 commits into from
Jan 16, 2026
Merged

[Model Download] Fix failing unit test cases #1529

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ff60d98
Fix failing test cases
madhuri-rai07 Dec 8, 2025
5f9a13a
Merge branch 'open-edge-platform:main' into model-download-ut
madhuri-rai07 Jan 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions microservices/model-download/docs/user-guide/running-tests.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,9 +11,10 @@ You can use either traditional pip/venv or the modern uv tool for dependency man
#### Using uv

```bash
# Navigate to model-download service directory
cd microservices/model-download

# Install uv if not already installed
curl -LsSf https://astral.sh/uv/install.sh | sh
# or
pip install uv

# Create and activate virtual environment
Expand Down
8 changes: 4 additions & 4 deletions microservices/model-download/tests/unit/test_ultralytics_plugin.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -213,7 +213,7 @@ def test_download_success(self, mock_getenv, mock_call_script, ultralytics_plugi

assert result["model_name"] == "yolov8n.pt"
assert result["source"] == "ultralytics"
assert result["return_code"] == 0
assert result["success"] == True
assert "ultralytics" in result["download_path"]

@patch.object(UltralyticsDownloader, '_call_bash_script')
Expand Down Expand Up @@ -246,7 +246,7 @@ def test_download_without_quantization(self, mock_call_script, ultralytics_plugi

assert result["model_name"] == "yolov8n.pt"
assert result["source"] == "ultralytics"
assert result["return_code"] == 0
assert result["success"] == True

@patch.object(UltralyticsDownloader, '_call_bash_script')
@patch('os.getenv')
Expand Down Expand Up @@ -327,7 +327,7 @@ def test_download_different_parameters(self, mock_call_script, ultralytics_plugi
assert mock_call_script.call_count == expected_calls
assert result["model_name"] == model_name
assert result["source"] == "ultralytics"
assert result["return_code"] == 0
assert result["success"] == True

@patch('os.path.exists')
@patch('subprocess.Popen')
Expand Down Expand Up @@ -444,7 +444,7 @@ def test_end_to_end_download_workflow(self, mock_call_script, ultralytics_plugin
# Verify results
assert result["model_name"] == "yolov8n.pt"
assert result["source"] == "ultralytics"
assert result["return_code"] == 0
assert result["success"] == True
assert "ultralytics" in result["download_path"]

# Test post-processing
Expand Down