[DLStreamer] Extend latency tracer to support multiple pipelines/branches in the gst launch string #1543
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: xwu2intel <[email protected]>
Co-authored-by: xwu2intel <[email protected]>
Co-authored-by: xwu2intel <[email protected]>
Co-authored-by: xwu2intel <[email protected]>
Co-authored-by: xwu2intel <[email protected]>
Co-authored-by: xwu2intel <[email protected]>
…ltiple-sources Extend latency_tracer to support multiple GStreamer pipeline branches
Co-authored-by: xwu2intel <[email protected]>
Co-authored-by: xwu2intel <[email protected]>
Co-authored-by: xwu2intel <[email protected]>
Co-authored-by: xwu2intel <[email protected]>
Co-authored-by: xwu2intel <[email protected]>
…-tracer Add source_name and sink_name fields to latency tracer output
…pilot/remove-logging-overhead
Remove logging overhead in latency tracer for non-writable buffers
…ltiple-sources Copilot/extend latency tracer multiple sources
- Added find_upstream_source() function to recursively walk upstream - Modified do_push_buffer_pre() to use topology analysis - Updated cal_log_pipeline_latency() to use topology analysis - Simplified add_latency_meta() to remove source_element tracking Co-authored-by: xwu2intel <[email protected]>
- Updated README.md to explain topology analysis approach - Marked source_element field as deprecated in metadata header - Added detailed comments explaining the new implementation Co-authored-by: xwu2intel <[email protected]>
…used parameter - Added proper GST_ITERATOR_RESYNC and GST_ITERATOR_ERROR handling - Removed unused elem parameter from add_latency_meta() - Updated all call sites to use new signature Co-authored-by: xwu2intel <[email protected]>
…or skipped buffers Co-authored-by: xwu2intel <[email protected]>
…ification Fix latency tracer source identification via topology analysis
Co-authored-by: xwu2intel <[email protected]>
Co-authored-by: xwu2intel <[email protected]>
Fix duplicate logging and per-branch frame counters in latency_tracer
xwu2intel
requested review from
a team,
ZiningLi,
yangjianfeng1208 and
yunowo
as code owners
tbujewsk
changed the title
Co-authored-by: xwu2intel <[email protected]>
Co-authored-by: xwu2intel <[email protected]>
Co-authored-by: xwu2intel <[email protected]>
Co-authored-by: xwu2intel <[email protected]>
Co-authored-by: xwu2intel <[email protected]>
Co-authored-by: xwu2intel <[email protected]>
Support multiple pipelines (sequential and concurrent) in latency tracer
Contributor
|
Comment sent via email. |
tbujewsk
requested changes
Dec 16, 2025
Contributor
tbujewsk
left a comment
tbujewsk
left a comment
There was a problem hiding this comment.
please fix issues with the
- code-style
- check license headers
- static C/C++ code analysis -> coverity scans
Skip pylint,yamllint,shellcheck scans.
tjanczak
reviewed
Dec 18, 2025
Contributor
tjanczak
left a comment
tjanczak
left a comment
There was a problem hiding this comment.
Xintian, you were showing built-in latency tracers (in GStreamer) work for both single and mutli pipelines. In that case, I'd rather write a sample how to measure latency using built-pin tracers and remove DLS-streamer custom traces. This will save our maintenance effort going forward.
Contributor
Author
The built-in latency tracer carries significant performance overhead. Although the result is right, the performance degradation makes it inadequate to use in the sample optimization. Please, this PR already implemented the required feature and has been validated. |
Contributor
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The existing latency tracer only supports a single pipeline/branch in the gst launch string. This patch extends the support to multiple pipelines/branches. Also included is performance optimization to reduce tracing overhead.
Any Newly Introduced Dependencies
N/A
How Has This Been Tested?
Unit tested with common pipelines
Checklist: