[DLStreamer] Merge gvawatermark3d and gvadeskew into gstvideoanalytics library #1591
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yunowo
reviewed
Dec 18, 2025
Comment on lines
421
to
426
| static gboolean plugin_init(GstPlugin *plugin) { | ||
| return gst_element_register(plugin, "gvadeskew", GST_RANK_NONE, GST_TYPE_GVADESKEW); | ||
| if (!gst_element_register(plugin, "gvadeskew", GST_RANK_NONE, GST_TYPE_GVADESKEW)) | ||
| return FALSE; | ||
|
|
||
| return TRUE; | ||
| } |
Member
There was a problem hiding this comment.
This init function is no longer needed
Contributor
Author
There was a problem hiding this comment.
In other plugins plugin_init (in gstvideoanalitics library) is included, and without it we`ve got compilation errors:
https://github.com/open-edge-platform/edge-ai-libraries/blob/main/libraries/dl-streamer/src/monolithic/gst/elements/gvawatermark/gvawatermark.cpp#L672-L680
yunowo
reviewed
Dec 18, 2025
Comment on lines
+312
to
+318
| static gboolean plugin_init(GstPlugin *plugin) { | ||
| if (!gst_element_register(plugin, "gvawatermark3d", GST_RANK_NONE, GST_TYPE_GVAWATERMARK3D)) | ||
| return FALSE; | ||
|
|
||
| return TRUE; | ||
| } | ||
|
|
Member
There was a problem hiding this comment.
This init function is no longer needed
mholowni
requested review from
BaoHuiling,
OskarFiedot,
ZiningLi,
dmichalo,
jmotow,
marcin-wadolkowski,
msmiatac,
nszczygl9,
pbartosik,
qianlongding,
tbujewsk and
yangjianfeng1208
as code owners
jmotow
previously approved these changes
Dec 18, 2025
yunowo
reviewed
Dec 19, 2025
| return TRUE; | ||
| } | ||
|
|
||
| GST_PLUGIN_DEFINE(GST_VERSION_MAJOR, GST_VERSION_MINOR, gvadeskew, PRODUCT_FULL_NAME " gvadeskew element", plugin_init, |
Member
There was a problem hiding this comment.
You forgot to remove this reference to plugin_init here, so you have compilation error.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Merged
gvawatermark3dandgvadeskewinto top level library to reduce dlls/so files.Any Newly Introduced Dependencies
N/A
How Has This Been Tested?
Checklist: