Partition extend device filtering across graphical &terminal installations #586
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jkintalix
changed the title
Jkintalix
force-pushed
the
fix/filter-usb-iso-vfat-media
branch
2 times, most recently
from
31e4226 to
10c46a4
Compare
Jkintalix
force-pushed
the
fix/filter-usb-iso-vfat-media
branch
from
10c46a4 to
c893df0
Compare
…allers Graphical installer (Calamares) now uses a unified iso9660/vfat detection function based on blkid to identify ISO and FAT-based bootable USB media. These devices are excluded from the list of installation targets. Terminal installer (diskutils.go) has been updated to extend read-only media detection using /proc/mounts, covering iso9660 and FAT (vfat/fat32) filesystems, including Rufus-created USB drives. This ensures consistent filtering across both installers and prevents the UEFI bootable USB drive from appearing as a valid installation destination. Signed-off-by: kinatli jayanth <jayanthx.kintali@intel.com>
Jkintalix
force-pushed
the
fix/filter-usb-iso-vfat-media
branch
from
c893df0 to
2fe1242
Compare
cheeyanglee
approved these changes
Nov 20, 2025
cheeyanglee
merged commit 33dcbec
into
open-edge-platform:3.0-dev
16 of 19 checks passed
liulis-sg
pushed a commit
that referenced
this pull request
Nov 25, 2025
…allers (#586) Graphical installer (Calamares) now uses a unified iso9660/vfat detection function based on blkid to identify ISO and FAT-based bootable USB media. These devices are excluded from the list of installation targets. Terminal installer (diskutils.go) has been updated to extend read-only media detection using /proc/mounts, covering iso9660 and FAT (vfat/fat32) filesystems, including Rufus-created USB drives. This ensures consistent filtering across both installers and prevents the UEFI bootable USB drive from appearing as a valid installation destination. Signed-off-by: kinatli jayanth <jayanthx.kintali@intel.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Graphical installer (Calamares) now uses a unified iso9660/vfat detection function based on blkid to identify ISO and FAT-based bootable USB media. These devices are excluded from the list of installation targets.
Terminal installer (diskutils.go) has been updated to extend read-only media detection using /proc/mounts, covering iso9660 and FAT (vfat/fat32) filesystems, including Rufus-created USB drives.
This ensures consistent filtering across both installers and prevents the UEFI bootable USB drive from appearing as a valid installation destination.
Merge Checklist
All boxes should be checked before merging the PR
Description
ITEP-81482: During EMT ISO installation using a bootable USB drive, the installer was incorrectly listing the UEFI USB device (containing the ISO image) as a valid installation target in both Terminal and Graphical installer modes, which could lead to data loss or incomplete installation if the user selected the USB drive as the destination. This patch introduces unified filtering logic to prevent such scenarios by detecting and excluding all installation media types, including iso9660 filesystems from DD-flashed ISOs or CD/DVDs, FAT/VFAT/FAT32 USB devices created using tools like Rufus, and read-only USB partitions that contain “CDROM” signatures. With these improvements, both Calamares and the terminal installer consistently filter out bootable USB/ISO media, ensuring they no longer appear in the list of valid installation targets.
Any Newly Introduced Dependencies
NO
How Has This Been Tested?
Manually tested