ip4save config change

[chrngc]

Merge Checklist

All boxes should be checked before merging the PR

• [v] The changes in the PR have been built and tested
• [] cgmanifest file has been updated if required
• [v] Ready to merge

Description

Allowed type 8 incoming ping requests in ip4save for iso image

Any Newly Introduced Dependencies

in edge-microvisor-toolkit/toolkit/imageconfigs/full.json, added configure-ip4save.sh as post-installation script from edge-microvisor-toolkit/toolkit/imageconfigs/additionalconfigs/

How Has This Been Tested?

Built the image, booted it in a vm, and cat /etc/systemd/scripts/ip4save

[andy-vm]

• please post jira ticket here for traceability
• please share icmp ping test result, e.g. ping is working as expected

[chrngc]

https://jira.devtools.intel.com/browse/ITEP-82486?filter=-3

[azril-ahmad]

Is there any concern if we modify directly to the ipv4 config file instead of creating post-script ?
https://github.com/open-edge-platform/edge-microvisor-toolkit/blob/3.0-dev/SPECS/iptables/ip4save

[cheeyanglee]

Is there any concern if we modify directly to the ipv4 config file instead of creating post-script ? https://github.com/open-edge-platform/edge-microvisor-toolkit/blob/3.0-dev/SPECS/iptables/ip4save

change in SPECS will make this change to all image

[azril-ahmad]

Is there any concern if we modify directly to the ipv4 config file instead of creating post-script ? https://github.com/open-edge-platform/edge-microvisor-toolkit/blob/3.0-dev/SPECS/iptables/ip4save

change in SPECS will make this change to all image

Yes know that, but what would be your recommendation @cheeyanglee ? since ICMP Type-8 (echo/ping) inbound is safe to enabled do we still required post-installation script ?

[cheeyanglee]

Yes know that, but what would be your recommendation @cheeyanglee ? since ICMP Type-8 (echo/ping) inbound is safe to enabled do we still required post-installation script ?

to me apply to SPECS are better option if this is also safe for immutable image. Otherwise we have no choice but to make it part of installation script.