Fixed some linter warnings

.github/workflows/check-circular-deps.yml

@@ -1,6 +1,6 @@
 # Copyright (c) Microsoft Corporation.
 # Licensed under the MIT License.
-
+---
 name: Circular dependency check
 
 on:
@@ -16,7 +16,7 @@ permissions: read-all
 jobs:
   spec-check:
     name: Circular dependency check
-    runs-on: [ ubuntu-latest ]
+    runs-on: ubuntu-latest
 
     steps:
       # Checkout the branch of our repo that triggered this action
@@ -28,7 +28,7 @@ jobs:
       - name: Check for circular dependencies
         run: |
           echo "Checking for circular dependency loops..."
-          # Call this script to sync the toolchain manifests with the LKG daily build.
+          # This will sync the toolchain manifests with the LKG daily build.
           #./toolkit/scripts/setuplkgtoolchain.sh
           # Determine the LKG daily build ID.
           #LKG_BUILD_ID=$(wget -qO - https://mariner3dailydevrepo.blob.core.windows.net/lkg/lkg-3.0-dev.json | jq -r ".dailybuildid" | tr '\.' '-')

.github/workflows/check-entangled-specs.yml

@@ -4,6 +4,7 @@
 # This action checks that certain groups of specs have matching tags.
 # The main use case is to ensure that signed specs have the same Version and
 #   Release tags as their unsigned counterparts
+---
 name: Spec Entanglement Mismatch Check
 
 on:
@@ -22,8 +23,8 @@ jobs:
         uses: actions/checkout@v4
         with:
           persist-credentials: false
-          
-      # For consistency, we use the same major/minor version of Python that Azure Linux ships
+
+      # We use the same major/minor version of Python that Azure Linux ships
       - name: Setup Python 3.12
         uses: actions/setup-python@v5
         with:

.github/workflows/check-license-map.yml

@@ -3,6 +3,7 @@
 
 # This action checks that the licenses.json file is up-to-date
 # and that the LICENSES-MAP.md file is up-to-date
+---
 name: Spec License Map Check
 
 on:
@@ -18,15 +19,15 @@ permissions: read-all
 jobs:
   check:
     name: Spec License Map Check
-    runs-on: [ ubuntu-latest ]
+    runs-on: ubuntu-latest
 
     steps:
       # Checkout the branch of our repo that triggered this action
       - name: Workflow trigger checkout
         uses: actions/checkout@v4
         with:
           persist-credentials: false
-          
+
       - name: Setup Python 3.12
         uses: actions/setup-python@v5
         with:

.github/workflows/check-manifests.yml

@@ -1,6 +1,6 @@
 # Copyright (c) Microsoft Corporation.
 # Licensed under the MIT License.
-
+---
 name: Check Manifests
 
 on:
@@ -17,28 +17,28 @@ permissions: read-all
 jobs:
   build:
     name: Check Manifests
-    runs-on: [ ubuntu-latest ]
+    runs-on: ubuntu-latest
 
     steps:
-    - name: Check out code
-      uses: actions/checkout@v4
-      with:
+      - name: Check out code
+        uses: actions/checkout@v4
+        with:
           persist-credentials: false
 
-    # This PR runner uses an older Ubuntu with rpm version 4.17, which doesn't understand some newer macros like %bcond
-    - name: Define missing rpm macros
-      run: |
-        if [[ -n $(rpm --eval '%bcond test 1') ]]; then
-          echo '%bcond() %[ (%{2}) ? "%{expand:%%bcond_without %{1}}" : "%{expand:%%bcond_with %{1}}" ]' > ~/.rpmmacros
-        fi
+      # This PR runner uses an older Ubuntu with rpm version 4.17, which doesn't understand some newer macros like %bcond
+      - name: Define missing rpm macros
+        run: |
+          if [[ -n $(rpm --eval '%bcond test 1') ]]; then
+            echo '%bcond() %[ (%{2}) ? "%{expand:%%bcond_without %{1}}" : "%{expand:%%bcond_with %{1}}" ]' > ~/.rpmmacros
+          fi
 
-    - name: Check x86_64 manifests
-      run: |
-        echo ##########
-        echo "Ensure toolchain and pkggen manifests (./toolkit/resources/manifests/package/*) match the versions in the .spec files"
-        echo "Run './scripts/toolchain/check_manifests.sh -a \"x86_64\"' to validate locally"
-        echo ##########
-        pushd toolkit
-        ./scripts/toolchain/check_manifests.sh -a "x86_64"
-        popd
-      shell: bash
+      - name: Check x86_64 manifests
+        run: |
+          echo ##########
+          echo "Ensure toolchain and pkggen manifests (./toolkit/resources/manifests/package/*) match the versions in the .spec files"
+          echo "Run './scripts/toolchain/check_manifests.sh -a \"x86_64\"' to validate locally"
+          echo ##########
+          pushd toolkit
+          ./scripts/toolchain/check_manifests.sh -a "x86_64"
+          popd
+        shell: bash

.github/workflows/check-package-cgmanifest.yml

@@ -1,6 +1,6 @@
 # Copyright (c) Microsoft Corporation.
 # Licensed under the MIT License.
-
+---
 name: Check Package CGManifests
 
 on:
@@ -20,44 +20,44 @@ jobs:
     runs-on: [ubuntu-latest]
 
     steps:
-    - name: Check out code
-      uses: actions/checkout@v4
-      with:
+      - name: Check out code
+        uses: actions/checkout@v4
+        with:
           persist-credentials: false
 
-    # This PR runner uses an older Ubuntu with rpm version 4.17, which doesn't understand some newer macros like %bcond
-    - name: Define missing rpm macros
-      run: |
-        if [[ -n $(rpm --eval '%bcond test 1') ]]; then
-          echo '%bcond() %[ (%{2}) ? "%{expand:%%bcond_without %{1}}" : "%{expand:%%bcond_with %{1}}" ]' > ~/.rpmmacros
-        fi
-
-    - name: Get base commit for PRs
-      if: ${{ github.event_name == 'pull_request' }}
-      run: |
-        base_ref="${BASE_REF}"
-        git fetch origin $base_ref
-        echo "base_sha=$(git rev-parse origin/$base_ref)" >> "$GITHUB_ENV"
-        echo "Merging ${{ github.sha }} into $base_ref"
-      env:
-        BASE_REF: ${{ github.base_ref }}
-
-    - name: Get base commit for Pushes
-      if: ${{ github.event_name == 'push' }}
-      run: |
-        git fetch origin ${{ github.event.before }}
-        echo "base_sha=${{ github.event.before }}" >> "$GITHUB_ENV"
-        echo "Merging ${{ github.sha }} into ${{ github.event.before }}"
-
-    - name: Get the changed files
-      run: |
-        echo "Files changed: '$(git diff-tree --no-commit-id --name-only -r ${{ env.base_sha }} ${{ github.sha }})'"
-        changed_specs=$(git diff-tree --diff-filter=d  --no-commit-id --name-only -r ${{ env.base_sha }} ${{ github.sha }} | { grep "SPECS.*/.*\.spec$" || test $? = 1; } | awk '{printf "%s ", $0}') 
-        echo "Files to validate: '${changed_specs}'"
-        echo "updated-specs=${changed_specs}" >> "$GITHUB_ENV"
-
-    - name: Check each spec
-      run: |
-        .github/workflows/overwrite_shell_link.sh
-        .github/workflows/validate-cg-manifest.sh ${{ env.updated-specs }}
-      shell: bash
+      # This PR runner uses an older Ubuntu with rpm version 4.17, which doesn't understand some newer macros like %bcond
+      - name: Define missing rpm macros
+        run: |
+          if [[ -n $(rpm --eval '%bcond test 1') ]]; then
+            echo '%bcond() %[ (%{2}) ? "%{expand:%%bcond_without %{1}}" : "%{expand:%%bcond_with %{1}}" ]' > ~/.rpmmacros
+          fi
+
+      - name: Get base commit for PRs
+        if: ${{ github.event_name == 'pull_request' }}
+        run: |
+          base_ref="${BASE_REF}"
+          git fetch origin $base_ref
+          echo "base_sha=$(git rev-parse origin/$base_ref)" >> "$GITHUB_ENV"
+          echo "Merging ${{ github.sha }} into $base_ref"
+        env:
+          BASE_REF: ${{ github.base_ref }}
+
+      - name: Get base commit for Pushes
+        if: ${{ github.event_name == 'push' }}
+        run: |
+          git fetch origin ${{ github.event.before }}
+          echo "base_sha=${{ github.event.before }}" >> "$GITHUB_ENV"
+          echo "Merging ${{ github.sha }} into ${{ github.event.before }}"
+
+      - name: Get the changed files
+        run: |
+          echo "Files changed: '$(git diff-tree --no-commit-id --name-only -r ${{ env.base_sha }} ${{ github.sha }})'"
+          changed_specs=$(git diff-tree --diff-filter=d  --no-commit-id --name-only -r ${{ env.base_sha }} ${{ github.sha }} | { grep "SPECS.*/.*\.spec$" || test $? = 1; } | awk '{printf "%s ", $0}')
+          echo "Files to validate: '${changed_specs}'"
+          echo "updated-specs=${changed_specs}" >> "$GITHUB_ENV"
+
+      - name: Check each spec
+        run: |
+          .github/workflows/overwrite_shell_link.sh
+          .github/workflows/validate-cg-manifest.sh ${{ env.updated-specs }}
+        shell: bash

.github/workflows/check-source-signatures.yml

@@ -1,6 +1,6 @@
 # Copyright (c) Microsoft Corporation.
 # Licensed under the MIT License.
-
+---
 name: Source Signature Check
 
 on:
@@ -16,7 +16,7 @@ permissions: read-all
 jobs:
   spec-check:
     name: Source Signature Check
-    runs-on: [ ubuntu-latest ]
+    runs-on: ubuntu-latest
     strategy:
       matrix:
         specs-dir: [SPECS, SPECS-EXTENDED]

.github/workflows/check-spec.yml

@@ -1,6 +1,6 @@
 # Copyright (c) Microsoft Corporation.
 # Licensed under the MIT License.
-
+---
 name: Spec files check
 
 on:
@@ -16,7 +16,7 @@ permissions: read-all
 jobs:
   spec-check:
     name: Spec files check
-    runs-on: [ ubuntu-latest ]
+    runs-on: ubuntu-latest
 
     steps:
       # Checkout the branch of our repo that triggered this action

.github/workflows/check-static-glibc.yml

@@ -1,6 +1,6 @@
 # Copyright (c) Microsoft Corporation.
 # Licensed under the MIT License.
-
+---
 name: Static glibc version check
 
 on:
@@ -16,7 +16,7 @@ permissions: read-all
 jobs:
   spec-check:
     name: Static glibc version check
-    runs-on: [ ubuntu-latest ]
+    runs-on: ubuntu-latest
 
     steps:
       # Checkout the branch of our repo that triggered this action