Skip to content

Apply review feedback: use standard comments and tmp_path fixture#485

Closed
Copilot wants to merge 2 commits intomgumowsk/GETI-480-adjusting-visualization-to-image-sizefrom
copilot/sub-pr-482
Closed

Apply review feedback: use standard comments and tmp_path fixture#485
Copilot wants to merge 2 commits intomgumowsk/GETI-480-adjusting-visualization-to-image-sizefrom
copilot/sub-pr-482

Conversation

Copy link

Copilot AI commented Feb 17, 2026

Address code review feedback from PR #482 on visualization auto-scaling changes.

Changes

  • defaults.py: Replace triple-quoted strings with standard # comments to avoid creating module-level string constants at import time
  • test_auto_scale.py: Migrate from deprecated tmpdir to tmp_path fixture for pathlib-native testing, remove unused fixture parameters
# Before
def test_auto_scale_save(self, large_image, detection_result_large, tmpdir):
    path = Path(tmpdir) / "test_auto_scale.jpg"

# After  
def test_auto_scale_save(self, large_image, detection_result_large, tmp_path):
    path = tmp_path / "test_auto_scale.jpg"

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Co-authored-by: mgumowsk <19403637+mgumowsk@users.noreply.github.com>
Copilot AI changed the title [WIP] Add auto_scale parameter for visualization scaling Apply review feedback: use standard comments and tmp_path fixture Feb 17, 2026
Copilot AI requested a review from mgumowsk February 17, 2026 12:25
@mgumowsk mgumowsk closed this Feb 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants