Skip to content

fix(deps): pin onnxruntime to last version with python 3.10 support#488

Merged
tybulewicz merged 2 commits intomasterfrom
ttybulew/pin-onnxruntime
Feb 24, 2026
Merged

fix(deps): pin onnxruntime to last version with python 3.10 support#488
tybulewicz merged 2 commits intomasterfrom
ttybulew/pin-onnxruntime

Conversation

@tybulewicz
Copy link
Contributor

@tybulewicz tybulewicz commented Feb 23, 2026

What does this PR do?

Pins onnxruntime to a compatible version range to maintain Python 3.10 support, and adjusts Ruff configuration for underscore-prefixed unused variables.

@tybulewicz tybulewicz requested a review from Copilot February 23, 2026 08:05
@tybulewicz tybulewicz changed the title fix: pin onnxruntime to last version with python 3.10 support fix(deps): pin onnxruntime to last version with python 3.10 support Feb 23, 2026
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Pins onnxruntime to a compatible version range to maintain Python 3.10 support, and adjusts Ruff configuration for underscore-prefixed unused variables.

Changes:

  • Add an onnxruntime dependency constraint in pyproject.toml.
  • Move/standardize Ruff lint.dummy-variable-rgx setting placement under the lint config.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

mgumowsk
mgumowsk previously approved these changes Feb 23, 2026
@tybulewicz tybulewicz marked this pull request as ready for review February 23, 2026 08:20
@tybulewicz tybulewicz requested a review from a team as a code owner February 23, 2026 08:20
@github-actions github-actions bot added the build Related to build scripts label Feb 23, 2026
@tybulewicz tybulewicz added this pull request to the merge queue Feb 23, 2026
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 23, 2026
@tybulewicz tybulewicz added this pull request to the merge queue Feb 24, 2026
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 24, 2026
@tybulewicz tybulewicz added this pull request to the merge queue Feb 24, 2026
Merged via the queue into master with commit 9417d3c Feb 24, 2026
43 of 45 checks passed
@tybulewicz tybulewicz deleted the ttybulew/pin-onnxruntime branch February 24, 2026 11:13
@leoll2
Copy link

leoll2 commented Feb 24, 2026

Hi @tybulewicz, unfortunately this change breaks OTX. The pinned onnxruntime version (1.23.0) is incompatible with Python 3.14, supported by OTX. I'm sure there is a better solution, I can help finding it if you can share more details about the original intent of this PR. How does it ensure compatibility with Py 3.10 through pinning a dependency that wasn't pinned before?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

build Related to build scripts

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants