Skip to content

Add Debian#686

Closed
4nd3r wants to merge 2 commits into
open-eid:masterfrom
4nd3r:debian
Closed

Add Debian#686
4nd3r wants to merge 2 commits into
open-eid:masterfrom
4nd3r:debian

Conversation

@4nd3r

@4nd3r 4nd3r commented Aug 13, 2025

Copy link
Copy Markdown
Contributor

Fixes #685.

Signed-off-by: Ander Punnar ander@kvlt.ee

@4nd3r

4nd3r commented Aug 14, 2025

Copy link
Copy Markdown
Contributor Author

Wait with merge a bit, need to sort out few build failures:
https://github.com/4nd3r/libdigidocpp/actions

Weird that they showed up now, didn't happen before 🤷

Will rebase later.

@4nd3r
4nd3r marked this pull request as draft August 14, 2025 12:22
@4nd3r
4nd3r marked this pull request as ready for review August 14, 2025 17:36
@4nd3r

4nd3r commented Aug 14, 2025

Copy link
Copy Markdown
Contributor Author

Looks better now:
https://github.com/4nd3r/libdigidocpp/actions/runs/16972276007

Did few additional small changes:

  • For the sake of consistency, use codenames for both.
  • Adjusted the version string.
  • Use standard /etc/os-release instead of lsb_release.

If codenames for Ubuntšik are not fine, then I'll revert back to numbers.

Sadly, there's no better way to define the strategy matrix, because the previously proposed approach didn't behave correctly for Debian arches.

@4nd3r
4nd3r requested a review from metsma August 14, 2025 17:40
@metsma

metsma commented Sep 2, 2025

Copy link
Copy Markdown
Contributor

I think the Debian build job shouldn’t run on every commit — it duplicates the Ubuntu job (same toolchains, packages, etc.), slows down development, and wastes GitHub resources. The Debian build would be more useful as a release/nightly check rather than a per-commit CI step.

Could you please update the workflow so that the Debian build only runs:
• on tagged releases (or published GitHub releases),
• on nightly schedule (cron),
• and optionally via manual dispatch?

That way we still verify Debian builds regularly, but without slowing down day-to-day development.

@4nd3r

4nd3r commented Sep 2, 2025

Copy link
Copy Markdown
Contributor Author

It's not possible to have per-job triggers.

Moved to separate workflow with suggested triggers.

@metsma

metsma commented Sep 8, 2025

Copy link
Copy Markdown
Contributor

Based your changes, maybe something like this metsma@f4df5b1

@4nd3r

4nd3r commented Sep 8, 2025

Copy link
Copy Markdown
Contributor Author

Personally I dislike pipeline templating used this way, and stuffing everything into one single file. YAML-based engineering in itself is already hacks built on top of hacks. But if that gets the work done, then sure, let's have it.

@metsma

metsma commented Sep 8, 2025

Copy link
Copy Markdown
Contributor

I agree this is not optimal. But duplicating build similar instructions across different yaml files is also pain.
Maybe investigate https://docs.github.com/en/actions/tutorials/create-actions/create-a-composite-action this solution?

@4nd3r

4nd3r commented Sep 16, 2025

Copy link
Copy Markdown
Contributor Author

I solved my "problem" on my own and I'm not going to continue working on this PR.

Feel free to use this in any way you see fit.

@4nd3r 4nd3r closed this Sep 16, 2025
metsma added a commit that referenced this pull request Nov 7, 2025
* OpenSSL 3.5.4
* LibXML2 2.15.1
* xmlsec1 1.3.8

IB-8679, IB-8681, #686

Signed-off-by: Raul Metsma <raul@metsma.ee>
Co-authored-by: Ander Punnar <ander@kvlt.ee>
metsma added a commit to metsma/libdigidocpp that referenced this pull request Nov 11, 2025
* OpenSSL 3.5.4
* LibXML2 2.15.1
* xmlsec1 1.3.9

IB-8679, IB-8681, open-eid#686

Signed-off-by: Raul Metsma <raul@metsma.ee>
Co-authored-by: Ander Punnar <ander@kvlt.ee>
metsma added a commit that referenced this pull request Nov 12, 2025
* OpenSSL 3.5.4
* LibXML2 2.15.1
* xmlsec1 1.3.9

IB-8679, IB-8681, #686

Signed-off-by: Raul Metsma <raul@metsma.ee>
Co-authored-by: Ander Punnar <ander@kvlt.ee>
metsma added a commit that referenced this pull request Nov 14, 2025
* OpenSSL 3.5.4
* LibXML2 2.15.1
* xmlsec1 1.3.9

IB-8679, IB-8681, #686

Signed-off-by: Raul Metsma <raul@metsma.ee>
Co-authored-by: Ander Punnar <ander@kvlt.ee>
metsma added a commit that referenced this pull request Nov 21, 2025
* OpenSSL 3.5.4
* LibXML2 2.15.1
* xmlsec1 1.3.9

IB-8679, IB-8681, #686

Signed-off-by: Raul Metsma <raul@metsma.ee>
Co-authored-by: Ander Punnar <ander@kvlt.ee>
metsma added a commit that referenced this pull request Dec 3, 2025
* OpenSSL 3.5.4
* LibXML2 2.15.1
* xmlsec1 1.3.9

IB-8679, IB-8681, #686

Signed-off-by: Raul Metsma <raul@metsma.ee>
Co-authored-by: Ander Punnar <ander@kvlt.ee>
kristelmerilain pushed a commit that referenced this pull request Dec 3, 2025
* OpenSSL 3.5.4
* LibXML2 2.15.1
* xmlsec1 1.3.9

IB-8679, IB-8681, #686

Signed-off-by: Raul Metsma <raul@metsma.ee>
Co-authored-by: Ander Punnar <ander@kvlt.ee>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Debian?

2 participants