Skip to content

Conversation

@bparks13
Copy link
Member

@bparks13 bparks13 commented Aug 7, 2025

This PR changes the devices on hub 0 to use the hub clock instead of the frame clock to save timestamps.

Devices modified:

  • AnalogIO
  • DigitalIO
  • MemoryMonitor
  • HarpSyncInput

Fixes #141

@bparks13 bparks13 added this to the 0.1.1 milestone Aug 7, 2025
@bparks13 bparks13 requested a review from jonnew August 7, 2025 17:46
@bparks13 bparks13 self-assigned this Aug 7, 2025
@jonnew
Copy link
Contributor

jonnew commented Aug 7, 2025

@aacuevas I would like your opinion on this when you return.

@jonnew jonnew requested a review from aacuevas August 7, 2025 22:37
Base automatically changed from issue-130 to main August 8, 2025 14:21
@jonnew
Copy link
Contributor

jonnew commented Aug 11, 2025

This should really also be done to passthrough devices since these are really local devices that are pretending to be remote.

@aacuevas I believe that in ONI 2.0 we had plans to move the frame clock capture before data arbitration for all devices such that for hub 0 devices, hub clock and frame clock would be identical and for devices that are not on hub 0, frame clock would reflect the time of data capture rather than frame formation. Thus, this may be eventually be obsolete. @bparks13 for this reason, please put a note concerning this in the code. If this occurs then it will have no effect on the actual sample time data for local devices.

- Add note describing the current behavior and the plans in ONI 2.0 to change the behavior
@bparks13 bparks13 marked this pull request as draft August 12, 2025 17:55
@bparks13
Copy link
Member Author

Changing this to a draft until we can understand what is going on better with how the hub clock and frame clock are generated.

@jonnew
Copy link
Contributor

jonnew commented Aug 19, 2025

@bparks13 Can you please have somebody at the Allen capture data with two neuropixels 2.0 probes. Ideally this should be done with the bonsai library and all Frame and hub clock data saved so we can examine the jitter. Ideallyt this should be done in saline with a square wave applied via bath electrode, something like 1kHz should be good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

For Hub 0 devices, use hub clock instead of frame time

2 participants