Skip to content

Corrects the output to be PCIe host #153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Corrects the output to be PCIe host #153

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions Source/OnixSource.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -275,7 +275,7 @@ bool OnixSource::checkHubFirmwareCompatibility (std::shared_ptr<Onix1> context,

for (const auto& [hubIndex, hubId] : hubIds)
{
if (hubId == ONIX_HUB_FMCHOST) // NB: Breakout Board
if (hubId == ONIX_HUB_FMCHOST)
{
static constexpr int RequiredMajorVersion = 2;
uint32_t firmwareVersion = 0;
Expand All @@ -287,16 +287,16 @@ bool OnixSource::checkHubFirmwareCompatibility (std::shared_ptr<Onix1> context,
auto majorVersion = (firmwareVersion & 0xFF00) >> 8;
auto minorVersion = firmwareVersion & 0xFF;

LOGC ("Breakout board firmware version: v", majorVersion, ".", minorVersion);
LOGC ("PCIe Host firmware version: v", majorVersion, ".", minorVersion);

if (majorVersion != RequiredMajorVersion)
{
Onix1::showWarningMessageBoxAsync (
"Invalid Firmware Version",
"The breakout board firmware major version is v"
"The PCIe Host firmware major version is v"
+ std::to_string (majorVersion) + ", but this plugin is only compatible with v"
+ std::to_string (RequiredMajorVersion) + ". To use this plugin, upgrade the firmware"
+ " to a version that supports the breakout board v" + std::to_string (majorVersion));
+ std::to_string (RequiredMajorVersion) + ". To use this plugin, modify the firmware"
+ " to version v" + std::to_string (majorVersion));
return false;
}
}
Expand Down