Add support for single-shank Neuropixels 2.0 probes #493
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Deprecate the QuadShank classes in favor of the more generic configuration classes that can be either quad- or single-shank - Update shift register bit setting for single-shank probes - Add combo box to the 2.0 GUIs allowing the user to change the probe type
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
QuadShankclasses in favor of the more generic configuration classes that can be either quad- or single-shankFixes #446
View of the editor:
The properties will not appear different to the user, but on the backend the type has changed. This does not affect old versions being loaded, as the type is not recorded in the XML file, only the name and the properties.
Example GIF: Changing Probe Type Manually
In the above GIF, we can see how the user will interact with changing the probe type, and how it affects the drop-down menus for the reference and electrode presets.
Example GIF: Loading Saved Files and Loading Default Configuration
This example shows how the user can load a saved file (either single- or quad-shank); it gives a warning if the current probe type does not match the incoming type, but does allow the user to continue if they wish. If the types match then no warning is given.
The default configuration is based on the selected probe type.
Testing Required
I do not have access to a single-shank Neuropixels 2.0 probe, so this will need to be tested with one of those probes before we can merge this PR.