Skip to content

Windows Icons #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Windows Icons #3

wants to merge 2 commits into from

Conversation

aacuevas
Copy link

This PR has 2 commits:

  1. Adds some variants of Windows icon file (.ico) which can be suitable for different uses. It includes icons with and without text and with transparent or white background. As per Windows specifications, these icon files are created with multiple internal resolutions for different cases.
  2. Adds a project which compiles all the existing icons into a Resource-only .DLL. This can be used by different projects to get the icons from it. It is required for driver icon display, but the shared resource could be used by other software parts.

@aacuevas aacuevas assigned aacuevas and unassigned aacuevas Jan 20, 2025
@aacuevas aacuevas requested a review from jonnew January 20, 2025 15:47
@jonnew
Copy link
Member

jonnew commented Feb 9, 2025

Hey @aacuevas. Once we review and merge #5, lets revisit this with the updated logos. I will be more timely in my review then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonnew jonnew Awaiting requested review from jonnew

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aacuevas @jonnew