update to contributing #13
Conversation
Signed-off-by: David Hirsch <[email protected]> Signed-off-by: David Hirsch <[email protected]>
DavidPHirsch
requested review from
oleg-nenashev and
beeme1mr
as code owners
|
|
||
| We hold regular meetings which you can see [here](https://github.com/open-feature/community/#meetings-and-events). | ||
| * [New Contributor Guide](#contributing-guide) |
There was a problem hiding this comment.
what do you mean?
There was a problem hiding this comment.
I don't think this anchor exists.
|
|
||
| We hold regular meetings which you can see [here](https://github.com/open-feature/community/#meetings-and-events). | ||
| * [New Contributor Guide](#contributing-guide) |
There was a problem hiding this comment.
I don't think this anchor exists.
| * [Pull Request Lifecycle](#pull-request-lifecycle) | ||
| * [Development Environment Setup](#development-environment-setup) | ||
| * [Sign Your Commits](#sign-your-commits) | ||
| * [Pull Request Checklist](#pull-request-checklist) |
There was a problem hiding this comment.
I don't think this anchor exists.
|
|
||
| ⚠️ **Explain how to set up a development environment** | ||
|
|
||
| ## Sign Your Commits |
There was a problem hiding this comment.
Do you mean sign-off on your commits? Signed commits are different.
https://docs.github.com/en/authentication/managing-commit-signature-verification/signing-commits
| * The original github issue | ||
| * Our Slack channel | ||
|
|
||
| ## Pull Request Lifecycle (TODO) |
There was a problem hiding this comment.
Please add the PR lifecycle doc or remove this section.
|
|
||
| ⚠️ **Explain your pull request process** | ||
|
|
||
| ## Development Environment Setup (TODO) |
There was a problem hiding this comment.
You should likely remove this section. Configuring a development environment will vary wildly based on the repo.
|
@DavidPHirsch bump :) |
|
@DavidPHirsch another bump 😄 |
Signed-off-by: David Hirsch [email protected]
This PR
adding details to the contributing doc