-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new GC members, remove bootstrap GC #342
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@aepfli any suggestions on what I did wrong? |
aepfli
reviewed
Feb 5, 2024
there is a typo in the username, thats why it is complaining :) |
aepfli
approved these changes
Feb 6, 2024
dabeeeenster
approved these changes
Feb 6, 2024
beeme1mr
approved these changes
Feb 8, 2024
adding new gc to config Signed-off-by: David Hirsch <[email protected]>
Signed-off-by: David Hirsch <[email protected]>
Co-authored-by: Simon Schrottner <[email protected]> Signed-off-by: David Hirsch <[email protected]>
Signed-off-by: Michael Beemer <[email protected]>
1c1db48
to
1fca264
Compare
Signed-off-by: Michael Beemer <[email protected]>
Signed-off-by: Michael Beemer <[email protected]>
beeme1mr
approved these changes
Feb 9, 2024
jonathannorris
approved these changes
Feb 9, 2024
toddbaert
reviewed
Feb 9, 2024
toddbaert
reviewed
Feb 9, 2024
toddbaert
reviewed
Feb 9, 2024
toddbaert
reviewed
Feb 9, 2024
toddbaert
approved these changes
Feb 9, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor editorial comments.
Signed-off-by: Michael Beemer <[email protected]>
Co-authored-by: Todd Baert <[email protected]> Signed-off-by: Michael Beemer <[email protected]>
Co-authored-by: Todd Baert <[email protected]> Signed-off-by: Michael Beemer <[email protected]>
Co-authored-by: Todd Baert <[email protected]> Signed-off-by: Michael Beemer <[email protected]>
Signed-off-by: Michael Beemer <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adding gc to config, and org approvers