feat: loosen test instance interface to support various test frameworks #316 #319
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
February 4, 2025 22:04
Signed-off-by: ekarlso <[email protected]>
…ks (open-feature#317) Switch to `interface{ Name() string }` since testing.BB has `private` which blocks it from working. Signed-off-by: ekarlso <[email protected]>
ekarlso
changed the title
thomaspoignant
approved these changes
Feb 5, 2025
| @@ -29,7 +28,7 @@ type TestProvider struct { | |||
| } | |||
|
|
|||
| // UsingFlags sets flags for the scope of a test | |||
| func (tp TestProvider) UsingFlags(test *testing.T, flags map[string]memprovider.InMemoryFlag) { | |||
| func (tp TestProvider) UsingFlags(test interface{ Name() string }, flags map[string]memprovider.InMemoryFlag) { | |||
There was a problem hiding this comment.
Suggested change
| func (tp TestProvider) UsingFlags(test interface{ Name() string }, flags map[string]memprovider.InMemoryFlag) { | |
| type TestFramework = interface{ Name() string } | |
| func (tp TestProvider) UsingFlags(test TestFramework, flags map[string]memprovider.InMemoryFlag) { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat: loosen test instance interface to support various test frameworks (#317)
This PR
Use interface instead of testing.BB since it has private() that blocks use.
Related Issues
Fixes #316
Notes
Follow-up Tasks
How to test