feat: add Otel util func #325
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: bbland1 <[email protected]>
Signed-off-by: bbland1 <[email protected]>
Signed-off-by: bbland1 <[email protected]>
Signed-off-by: bbland1 <[email protected]>
Signed-off-by: bbland1 <[email protected]>
Signed-off-by: bbland1 <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #325 +/- ##
==========================================
+ Coverage 86.78% 88.13% +1.35%
==========================================
Files 13 14 +1
Lines 1362 1408 +46
==========================================
+ Hits 1182 1241 +59
+ Misses 156 143 -13
Partials 24 24
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
…e based on codecov report Signed-off-by: bbland1 <[email protected]>
…o set what is being set by the if-else Signed-off-by: bbland1 <[email protected]>
chrfwow
approved these changes
Feb 21, 2025
lukas-reining
approved these changes
Feb 21, 2025
bbland1
commented
Feb 24, 2025
beeme1mr
reviewed
Feb 24, 2025
…dability Signed-off-by: bbland1 <[email protected]>
liran2000
suggested changes
Feb 25, 2025
|
|
||
| contextID, exists := details.EvaluationDetails.ResolutionDetail.FlagMetadata[TelemetryFlagMetaContextId] | ||
| if exists && contextID != "" { | ||
| attributes[TelemetryFlagMetaContextId] = contextID |
There was a problem hiding this comment.
replace to TelemetryContextID ?
| if exists && contextID != "" { | ||
| attributes[TelemetryFlagMetaContextId] = contextID | ||
| } else { | ||
| attributes[TelemetryFlagMetaContextId] = hookContext.EvaluationContext().TargetingKey() |
There was a problem hiding this comment.
replace to TelemetryContextID ?
|
|
||
| setID, exists := details.EvaluationDetails.ResolutionDetail.FlagMetadata[TelemetryFlagMetaFlagSetId] | ||
| if exists { | ||
| attributes[TelemetryFlagMetaFlagSetId] = setID |
There was a problem hiding this comment.
replace to TelemetryFlagSetID ?
|
|
||
| version, exists := details.EvaluationDetails.ResolutionDetail.FlagMetadata[TelemetryFlagMetaVersion] | ||
| if exists { | ||
| attributes[TelemetryFlagMetaVersion] = version |
There was a problem hiding this comment.
replace to TelemetryVersion ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
Related Issues
Fixes #322
How to test