-
Notifications
You must be signed in to change notification settings - Fork 59
chore: mark multi-provider packages as deprecated #1395
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Jonathan Norris <[email protected]>
Summary of ChangesHello @jonathannorris, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request formally deprecates the standalone multi-provider packages for both web and server environments. This change streamlines the OpenFeature ecosystem by consolidating the multi-provider functionality directly into the respective main SDKs, guiding users towards a more integrated and simplified approach for managing multiple feature flag providers. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request correctly marks the @openfeature/multi-provider and @openfeature/multi-provider-web packages as deprecated by adding a deprecated field to their respective package.json files and including a deprecation notice in their READMEs. The changes are straightforward and align with the goal of migrating users to the main SDKs. I've suggested minor improvements to the README files to include direct links to the relevant SDK documentation, which will help users with the migration process.
Signed-off-by: Jonathan Norris <[email protected]>
Summary
Mark
@openfeature/multi-providerand@openfeature/multi-provider-webpackages as deprecated.The Multi-Provider functionality is now included directly in the main OpenFeature SDKs:
@openfeature/server-sdk@openfeature/web-sdk