refactor: use the noop-provider instead of null provider (#112)

Signed-off-by: Nicklas Lundin <[email protected]>
open-feature · Nov 18, 2024 · 1f59e3d · 1f59e3d
1 parent 6e9aa29
commit 1f59e3d
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 7 deletions.
diff --git a/android/src/main/java/dev/openfeature/sdk/OpenFeatureAPI.kt b/android/src/main/java/dev/openfeature/sdk/OpenFeatureAPI.kt
@@ -12,7 +12,8 @@ import kotlinx.coroutines.flow.flatMapLatest
 
 @Suppress("TooManyFunctions")
 object OpenFeatureAPI {
-    private var provider: FeatureProvider? = null
+    private val NOOP_PROVIDER = NoOpProvider()
+    private var provider: FeatureProvider = NOOP_PROVIDER
     private var context: EvaluationContext? = null
     private val providersFlow: MutableSharedFlow<FeatureProvider> = MutableSharedFlow(replay = 1)
     internal val sharedProvidersFlow: SharedFlow<FeatureProvider> get() = providersFlow
@@ -40,26 +41,26 @@ object OpenFeatureAPI {
         provider.awaitReadyOrError(dispatcher)
     }
 
-    fun getProvider(): FeatureProvider? {
+    fun getProvider(): FeatureProvider {
         return provider
     }
 
     fun clearProvider() {
-        provider = null
+        provider = NOOP_PROVIDER
     }
 
     fun setEvaluationContext(evaluationContext: EvaluationContext) {
         val oldContext = context
         context = evaluationContext
-        getProvider()?.onContextSet(oldContext, evaluationContext)
+        getProvider().onContextSet(oldContext, evaluationContext)
     }
 
     fun getEvaluationContext(): EvaluationContext? {
         return context
     }
 
     fun getProviderMetadata(): ProviderMetadata? {
-        return provider?.metadata
+        return provider.metadata
     }
 
     fun getClient(name: String? = null, version: String? = null): Client {
@@ -75,7 +76,7 @@ object OpenFeatureAPI {
     }
 
     fun shutdown() {
-        provider?.shutdown()
+        provider.shutdown()
     }
 
     /*

diff --git a/android/src/main/java/dev/openfeature/sdk/OpenFeatureClient.kt b/android/src/main/java/dev/openfeature/sdk/OpenFeatureClient.kt
@@ -168,7 +168,7 @@ class OpenFeatureClient(
         val options = optionsIn ?: FlagEvaluationOptions(listOf(), mapOf())
         val hints = options.hookHints
         var details = FlagEvaluationDetails(key, defaultValue)
-        val provider = openFeatureAPI.getProvider() ?: NoOpProvider()
+        val provider = openFeatureAPI.getProvider()
         val mergedHooks: List<Hook<*>> =
             provider.hooks + options.hooks + hooks + openFeatureAPI.hooks
         val context = openFeatureAPI.getEvaluationContext()