Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(flagd): migrate to new provider mode file and update e2e tests #121

Merged

Conversation

aepfli
Copy link
Member

@aepfli aepfli commented Dec 17, 2024

see open-feature/flagd#1504

this pr migrates the offline file provider in a backwards-compatible manner to its own provider.

Furthermore, we're updating the test harness to the new testbed approach.

@aepfli aepfli force-pushed the feat/gherkinmigration branch from bd916e4 to 527ce6b Compare December 17, 2024 20:08
@aepfli aepfli changed the title [Draft] improve gherkin setup based on current motivation feat(flagd): improve gherkin setup based on current motivation Dec 18, 2024
@aepfli aepfli changed the title feat(flagd): improve gherkin setup based on current motivation feat(flagd): improve gherkin setup based on current motivation -wip Dec 18, 2024
Signed-off-by: Simon Schrottner <[email protected]>
@aepfli aepfli force-pushed the feat/gherkinmigration branch from 527ce6b to 578692f Compare December 18, 2024 06:39
@aepfli aepfli changed the title feat(flagd): improve gherkin setup based on current motivation -wip test(flagd): improve gherkin setup based on current motivation -wip Dec 27, 2024
Copy link

codecov bot commented Dec 27, 2024

Codecov Report

Attention: Patch coverage is 95.12195% with 6 lines in your changes missing coverage. Please review.

Project coverage is 93.91%. Comparing base (02dcfc0) to head (a5990a3).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
.../flagd/resolvers/process/connector/file_watcher.py 94.28% 4 Missing ⚠️
...src/openfeature/contrib/provider/flagd/provider.py 80.00% 1 Missing ⚠️
.../contrib/provider/flagd/resolvers/process/flags.py 95.23% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #121      +/-   ##
==========================================
- Coverage   94.39%   93.91%   -0.48%     
==========================================
  Files          14       15       +1     
  Lines         749      789      +40     
==========================================
+ Hits          707      741      +34     
- Misses         42       48       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aepfli aepfli force-pushed the feat/gherkinmigration branch 4 times, most recently from 35790da to 455d51d Compare December 27, 2024 15:18
@aepfli aepfli force-pushed the feat/gherkinmigration branch from 455d51d to 9192c77 Compare December 27, 2024 15:19
@aepfli aepfli force-pushed the feat/gherkinmigration branch 6 times, most recently from 55feac0 to 1a8000b Compare January 8, 2025 19:31
@aepfli aepfli requested a review from a team as a code owner January 23, 2025 08:00
@aepfli aepfli force-pushed the feat/gherkinmigration branch 3 times, most recently from a65de3d to 581d759 Compare January 23, 2025 08:08
@aepfli aepfli changed the title test(flagd): improve gherkin setup based on current motivation -wip feat(flagd): improve gherkin setup based on current motivation -wip Jan 23, 2025
@aepfli aepfli changed the title feat(flagd): improve gherkin setup based on current motivation -wip feat(flagd): migrate to new provider mode file and update e2e tests Jan 23, 2025
@aepfli aepfli force-pushed the feat/gherkinmigration branch 5 times, most recently from db3f5f2 to 89c4eac Compare January 23, 2025 08:39
@aepfli aepfli force-pushed the feat/gherkinmigration branch from 89c4eac to c649799 Compare February 4, 2025 08:35
@aepfli aepfli force-pushed the feat/gherkinmigration branch 8 times, most recently from 77961c8 to 1e2803c Compare February 4, 2025 13:56
@aepfli aepfli force-pushed the feat/gherkinmigration branch from 1e2803c to 6a299b1 Compare February 4, 2025 17:33
@aepfli
Copy link
Member Author

aepfli commented Feb 4, 2025

@toddbaert @open-feature/sdk-python-maintainers please have a look

@aepfli aepfli force-pushed the feat/gherkinmigration branch from 6a299b1 to 1050ca0 Compare February 4, 2025 17:35
@aepfli aepfli force-pushed the feat/gherkinmigration branch from 1050ca0 to a5990a3 Compare February 4, 2025 17:36
@toddbaert toddbaert merged commit eed1ee0 into open-feature:main Feb 6, 2025
25 of 26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants