-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(flagd): migrate to new provider mode file and update e2e tests #121
Merged
toddbaert
merged 15 commits into
open-feature:main
from
open-feature-forking:feat/gherkinmigration
Feb 6, 2025
Merged
feat(flagd): migrate to new provider mode file and update e2e tests #121
toddbaert
merged 15 commits into
open-feature:main
from
open-feature-forking:feat/gherkinmigration
Feb 6, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Simon Schrottner <[email protected]>
Signed-off-by: Simon Schrottner <[email protected]>
Signed-off-by: Simon Schrottner <[email protected]>
Signed-off-by: Simon Schrottner <[email protected]>
Signed-off-by: Simon Schrottner <[email protected]>
Signed-off-by: Simon Schrottner <[email protected]>
Signed-off-by: Simon Schrottner <[email protected]>
bd916e4
to
527ce6b
Compare
Signed-off-by: Simon Schrottner <[email protected]>
527ce6b
to
578692f
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #121 +/- ##
==========================================
- Coverage 94.39% 93.91% -0.48%
==========================================
Files 14 15 +1
Lines 749 789 +40
==========================================
+ Hits 707 741 +34
- Misses 42 48 +6 ☔ View full report in Codecov by Sentry. |
35790da
to
455d51d
Compare
Signed-off-by: Simon Schrottner <[email protected]>
455d51d
to
9192c77
Compare
Signed-off-by: Simon Schrottner <[email protected]>
55feac0
to
1a8000b
Compare
a65de3d
to
581d759
Compare
db3f5f2
to
89c4eac
Compare
89c4eac
to
c649799
Compare
Signed-off-by: Simon Schrottner <[email protected]>
77961c8
to
1e2803c
Compare
beeme1mr
approved these changes
Feb 4, 2025
providers/openfeature-provider-flagd/tests/e2e/file/conftest.py
Outdated
Show resolved
Hide resolved
1e2803c
to
6a299b1
Compare
@toddbaert @open-feature/sdk-python-maintainers please have a look |
6a299b1
to
1050ca0
Compare
Signed-off-by: Simon Schrottner <[email protected]>
1050ca0
to
a5990a3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see open-feature/flagd#1504
this pr migrates the offline file provider in a backwards-compatible manner to its own provider.
Furthermore, we're updating the test harness to the new testbed approach.