Implement form.io email component type #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sergei-maertens
force-pushed
the
feature/component-type-email
branch
from
3186194 to
52e954f
Compare
|
Reference of formio:
|
sergei-maertens
added a commit
that referenced
this pull request
May 13, 2023
Centralized common schema validation such as label + key, in preparation for complexer component.type specific validations, using zod unions and intersections.
sergei-maertens
added a commit
that referenced
this pull request
May 13, 2023
This allows for re-using the error list between wrapper and 'atomic' components, especially for the multiple: true variant. NOTE: form.io itself always displays the errors at the wrapper level, but it should be better UX/a11y to display the errors precisely with the invalid input. There is definitely more to gain in terms of a11y here, e.g. with aria-describedby etc.
sergei-maertens
added a commit
that referenced
this pull request
May 13, 2023
* Added stories for configuration + preview * Implemented defaultValue builder form schema validation, taking into account the 'multiple' flag. * Added email to the supported components registry TODO (later) * validation in preview component * update preview when value of defaultValue in builder form changes
sergei-maertens
force-pushed
the
feature/component-type-email
branch
from
a094d15 to
4d06d35
Compare
sergei-maertens
added a commit
that referenced
this pull request
May 13, 2023
Centralized common schema validation such as label + key, in preparation for complexer component.type specific validations, using zod unions and intersections.
sergei-maertens
added a commit
that referenced
this pull request
May 13, 2023
This allows for re-using the error list between wrapper and 'atomic' components, especially for the multiple: true variant. NOTE: form.io itself always displays the errors at the wrapper level, but it should be better UX/a11y to display the errors precisely with the invalid input. There is definitely more to gain in terms of a11y here, e.g. with aria-describedby etc.
sergei-maertens
added a commit
that referenced
this pull request
May 13, 2023
* Added stories for configuration + preview * Implemented defaultValue builder form schema validation, taking into account the 'multiple' flag. * Added email to the supported components registry TODO (later) * validation in preview component * update preview when value of defaultValue in builder form changes
sergei-maertens
force-pushed
the
feature/component-type-email
branch
2 times, most recently
from
779732e to
90ed545
Compare
sergei-maertens
commented
May 13, 2023
SilviaAmAm
reviewed
May 31, 2023
There was a problem hiding this comment.
I noticed while playing with storybook that if you do this:
- Let the story do its play tests
- Uncheck the 'multiple' checkbox
Then the defaultValue remains:
"defaultValue": [
"invalid",
""
]
And it displays as:
(not sure if this is something that will be fixed in other PRs)
Comment on lines
+157
to
+158
| show: undefined, | ||
| when: '', |
There was a problem hiding this comment.
I think these are both null to start with in Formio? Not sure if it is a problem
There was a problem hiding this comment.
yeah, but their own type definitions don't allow for null and using null violates the typescript types, which breaks compilation. A typical example of form.io not sticking to their own semantics 😬
| return ( | ||
| <TextField | ||
| name={name} | ||
| multiple={!!multiple} |
There was a problem hiding this comment.
Isn't multiple already a bool? 🤔
There was a problem hiding this comment.
it can also be undefined as it's an optional prop for the preview
Yep, it's a known issue and tracked in #21 |
sergei-maertens
force-pushed
the
feature/component-type-email
branch
from
6c35f8c to
bee7fb9
Compare
|
Back to draft - I'll get the refactors in a separate PR and sort out adding the typescript types first. |
sergei-maertens
force-pushed
the
feature/component-type-email
branch
from
bee7fb9 to
a02ba2e
Compare
* Added stories for configuration + preview * Implemented defaultValue builder form schema validation, taking into account the 'multiple' flag. * Added email to the supported components registry TODO (later) * validation in preview component * update preview when value of defaultValue in builder form changes
sergei-maertens
force-pushed
the
feature/component-type-email
branch
from
a02ba2e to
b5a7b1b
Compare
sergei-maertens
commented
Aug 25, 2023
| <Tabs> | ||
| <TabList> | ||
| <Tab | ||
| hasErrors={hasAnyError( |
There was a problem hiding this comment.
I don't find this particularly elegant, but I don't know how to fix it either. The field name (and thus the error key) is deeply nested, and the field itself does not know in which tab it's being displayed.
sergei-maertens
force-pushed
the
feature/component-type-email
branch
from
47de2ec to
941ea59
Compare
SilviaAmAm
approved these changes
Aug 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #18
design decisions to make/think about
-> pushed preview validation to separate issue #19
tasks