Add modal component #176
Merged
Add modal component #176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Like in open-forms and open-forms-sdk, we use the same proven library to implement modals.
Formio's modal component is based on or inspired by bootstrap. To make transitioning easier, we apply the same formio classnames so that we can share the styling. The modal implementation needs some tweaking to match the markup used in Formio/bootstrap, but other than that it's pretty straight forward. The ModalContext primarily serves to mute warnings and make interaction testing easier in Storybook, by: * disabling the aria-hidden integration on the app element * injecting the modal node in the right place in the DOM so that it's within the canvas
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Required for #175 where clicking the edit icon/pencil will bring up the component definition in a modal.
This is currently managed in https://github.com/open-formulieren/open-forms by the formio.js webform builder, which we want to replace.