Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OF#5086] Fix showing soft requirement warning in hidden components #795

Merged

Conversation

vaszig
Copy link
Contributor

@vaszig vaszig commented Feb 17, 2025

@vaszig vaszig added the needs-backport Fix must be backported to stable release branch label Feb 17, 2025
Copy link

codecov bot commented Feb 17, 2025

Bundle Report

Changes will increase total bundle size by 52 bytes (0.0%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
@open-formulieren/sdk-OpenForms-umd 4.78MB 26 bytes (0.0%) ⬆️
@open-formulieren/sdk-esm 4.75MB 26 bytes (0.0%) ⬆️

Affected Assets, Files, and Routes:

view changes for bundle: @open-formulieren/sdk-OpenForms-umd

Assets Changed:

Asset Name Size Change Total Size Change (%)
open-*.js 26 bytes 3.49MB 0.0%

Files in open-*.js:

  • ./src/formio/components/SoftRequiredErrors.js → Total Size: 1.89kB
view changes for bundle: @open-formulieren/sdk-esm

Assets Changed:

Asset Name Size Change Total Size Change (%)
assets/formio-*.js 26 bytes 2.03MB 0.0%

Files in assets/formio-*.js:

  • ./src/formio/components/SoftRequiredErrors.js → Total Size: 1.89kB

Copy link

codecov bot commented Feb 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.89%. Comparing base (f2afabf) to head (dd4e786).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #795      +/-   ##
==========================================
- Coverage   83.90%   83.89%   -0.02%     
==========================================
  Files         246      246              
  Lines        4816     4817       +1     
  Branches     1282     1275       -7     
==========================================
  Hits         4041     4041              
- Misses        746      747       +1     
  Partials       29       29              
Flag Coverage Δ
storybook 77.49% <100.00%> (-0.04%) ⬇️
vitest 62.63% <100.00%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vaszig vaszig force-pushed the of-5086/fix-soft-requirement-shown-in-hidden-fieldset branch from 965f4a3 to 40028f1 Compare February 17, 2025 14:25
Copy link
Contributor

@viktorvanwijk viktorvanwijk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few minor remarks/questions :)

@vaszig vaszig force-pushed the of-5086/fix-soft-requirement-shown-in-hidden-fieldset branch from 40028f1 to 3b142ff Compare February 21, 2025 13:02
@vaszig vaszig force-pushed the of-5086/fix-soft-requirement-shown-in-hidden-fieldset branch from 3b142ff to cea8518 Compare February 27, 2025 15:30
@vaszig vaszig force-pushed the of-5086/fix-soft-requirement-shown-in-hidden-fieldset branch from cea8518 to dd4e786 Compare February 28, 2025 06:48
@sergei-maertens sergei-maertens merged commit adf8ff7 into main Feb 28, 2025
16 of 17 checks passed
@sergei-maertens sergei-maertens deleted the of-5086/fix-soft-requirement-shown-in-hidden-fieldset branch February 28, 2025 11:01
sergei-maertens pushed a commit that referenced this pull request Feb 28, 2025
@sergei-maertens
Copy link
Member

Backported to 3.0.x in 29ccec8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-backport Fix must be backported to stable release branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Soft requirement of uploads in field-set trigger warning when not visible
3 participants