-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[OF#5086] Fix showing soft requirement warning in hidden components #795
[OF#5086] Fix showing soft requirement warning in hidden components #795
Conversation
Bundle ReportChanges will increase total bundle size by 52 bytes (0.0%) ⬆️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: @open-formulieren/sdk-OpenForms-umdAssets Changed:
Files in
view changes for bundle: @open-formulieren/sdk-esmAssets Changed:
Files in
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #795 +/- ##
==========================================
- Coverage 83.90% 83.89% -0.02%
==========================================
Files 246 246
Lines 4816 4817 +1
Branches 1282 1275 -7
==========================================
Hits 4041 4041
- Misses 746 747 +1
Partials 29 29
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
965f4a3
to
40028f1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few minor remarks/questions :)
40028f1
to
3b142ff
Compare
3b142ff
to
cea8518
Compare
…ning in hidden components
cea8518
to
dd4e786
Compare
…ning in hidden components Backport-of: #795
Backported to 3.0.x in 29ccec8 |
Fixes open-formulieren/open-forms#5086