[OF#5086] Fix showing soft requirement warning in hidden components #795
Conversation
Bundle ReportChanges will increase total bundle size by 146 bytes (0.0%) ⬆️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: @open-formulieren/sdk-OpenForms-umdAssets Changed:
Files in
view changes for bundle: @open-formulieren/sdk-esmAssets Changed:
Files in
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #795 +/- ##
==========================================
+ Coverage 83.90% 84.18% +0.27%
==========================================
Files 246 246
Lines 4816 4819 +3
Branches 1282 1282
==========================================
+ Hits 4041 4057 +16
+ Misses 746 733 -13
Partials 29 29
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
vaszig
force-pushed
the
of-5086/fix-soft-requirement-shown-in-hidden-fieldset
branch
from
965f4a3 to
40028f1
Compare
vaszig
force-pushed
the
of-5086/fix-soft-requirement-shown-in-hidden-fieldset
branch
from
40028f1 to
3b142ff
Compare
| @@ -33,7 +33,11 @@ class SoftRequiredErrors extends FormioContentField { | |||
| // check which components have an empty value | |||
| for (const component of softRequiredComponents) { | |||
| const isEmpty = component.isEmpty(); | |||
| if (isEmpty) missingFieldLabels.push(component.label); | |||
| const isParentVisible = component.parent?.visible; | |||
There was a problem hiding this comment.
what it the grand parent is hidden?
There was a problem hiding this comment.
Yes, you are right I didn't think about it.
There was a problem hiding this comment.
After some research I saw that even if we have nested components this works. If, as you mentioned, the grand parent is hidden, all the children are hidden as well. I understood that formio (the UI) does not render the children of a hidden component, even if the json configuration has hidden=false.
There was a problem hiding this comment.
That's correct - I just didn't know if component.visible took into account is parents or not :) So, do we then need the isParentVisible check or not? I'd expect that component.visible already checks that, no?
…ning in hidden components
vaszig
force-pushed
the
of-5086/fix-soft-requirement-shown-in-hidden-fieldset
branch
from
3b142ff to
cea8518
Compare
Fixes open-formulieren/open-forms#5086