Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch release 3.0.5 #5128

Open
wants to merge 2 commits into
base: stable/3.0.x
Choose a base branch
from
Open

Patch release 3.0.5 #5128

wants to merge 2 commits into from

Conversation

robinmolen
Copy link
Contributor

@robinmolen robinmolen commented Feb 27, 2025

Partly closes #5126

Changes

Patch release for 3.0.5. Updated backend translations and changelog, and bumped version

Checklist

Check off the items that are completed or not relevant.

  • Impact on features

    • Checked copying a form
    • Checked import/export of a form
    • Config checks in the configuration overview admin page
    • Problem detection in the admin email digest is handled
  • Release management

    • I have labelled the PR as "needs-backport" accordingly
  • I have updated the translations assets (you do NOT need to provide translations)

    • Ran ./bin/makemessages_js.sh
    • Ran ./bin/compilemessages_js.sh
  • Dockerfile/scripts

    • Updated the Dockerfile with the necessary scripts from the ./bin folder
  • Commit hygiene

    • Commit messages refer to the relevant Github issue
    • Commit messages explain the "why" of change, not the how

@robinmolen robinmolen linked an issue Feb 27, 2025 that may be closed by this pull request
10 tasks
Copy link

codecov bot commented Feb 27, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.67%. Comparing base (4b1ecdf) to head (902f91a).

Additional details and impacted files
@@              Coverage Diff              @@
##           stable/3.0.x    #5128   +/-   ##
=============================================
  Coverage         96.67%   96.67%           
=============================================
  Files               762      762           
  Lines             26012    26012           
  Branches           3401     3401           
=============================================
  Hits              25148    25148           
  Misses              600      600           
  Partials            264      264           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Comment on lines +14 to +15
* [:backend:`5086`, :backend:`5090`] Fixed soft-required errors being shown for hidden
upload fields and blocking going to the next form step.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this warrants a possible manual intervention warning - existing forms need to be updated, the validate: required configuration should be removed by editing the JSON directly.

upload fields and blocking going to the next form step.
* [:backend:`5039`] Fixed some error messages not shown properly in the Email
Registration plugin.
* Fixed performance issues causing long loading times for citizens when using forms.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* Fixed performance issues causing long loading times for citizens when using forms.
* Worked around some performance issues while evaluating form logic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Prepare patch releases
2 participants