Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[high fps] fix blinking in all games #3759

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

SuperSamus
Copy link
Contributor

@SuperSamus SuperSamus commented Nov 12, 2024

Fixes both interval and animation speed. (jak1 previously only had a fix for the former.)
This should close #3518, and one of the issues of #1499.

The solution is not the cleanest. The results are going to be wrong in case the FPS doesn't reach the maximum set.
A better solution would be to make random-time a float, so that it can be subtracted by time-adjust-ratio, but I don't know if changing a type for this purpose is allowed here. Tell me if I should do that instead.

Tested only on jak2.

@OpenGOALBot
Copy link
Collaborator

Can one of the admins verify this patch?

@BreakPoints
Copy link
Contributor

REPL compile error on Jak 3

Reader error:   ]       goal_src/jak3/engine/gfx/foreground/eye.gc
failed to find close paren
at H:\Coding\jak-project\goal_src\jak3\engine\gfx\foreground\eye.gc:1072
  )
   ^
Compilation failed: Reader error:
failed to find close paren
at H:\Coding\jak-project\goal_src\jak3\engine\gfx\foreground\eye.gc:1072
  )
   ^

Build failed on goal_src/jak3/engine/gfx/foreground/eye.gc
Code:
(make "GROUP:iso" :verbose #f :force #f :report #f)
From macro: make-group

Fixes both interval and animation speed. (jak1 previously only had a fix for the former.)
Copy link

@ATerbrack ATerbrack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like your one failing check is just a newline/formatting issue.
lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

[Jak2/3] [fps] Blink animation too fast
4 participants