Issue1482 Open Modelica errors and syntax warnings#1484
Conversation
…using warnings in OpenModelica
|
@lucasverleyen Could you take a quick look at this PR? If everything is fine, can we merge it? |
lucasverleyen
left a comment
There was a problem hiding this comment.
PR looks fine!
One general comment: you did not include any revision history in the models. Might be good and helpful for others if you add the revision history explaining what you changed to be OM compatible (or referring to the issue/PR in GitHub).
Other comments concert details and are rather suggestions for the future.
Thanks a lot for addressing this issue! :)
| A | ||
| B | ||
| C |
There was a problem hiding this comment.
If I am right, this change has nothing to do with syntax, but with the duplicate names in the .order file (which can raise an issue in OMEdit)?
There was a problem hiding this comment.
yes, indeed. It gave a warning in OM.
…lectorValidation.mo Co-authored-by: Lucas Verleyen <48284460+lucasverleyen@users.noreply.github.com>
…DynamicCollectorValidation.mo Co-authored-by: Lucas Verleyen <48284460+lucasverleyen@users.noreply.github.com>
…S into issue1482_OMSyntaxErrors
Fix OpenModelica Syntax Errors in PPD12 and PVT Validation Models
This PR resolves syntax and parsing issues reported in #1482, which prevented IDEAS v4.0.0 (master) from loading in OpenModelica 1.25.5. All changes are backward‑compatible with Dymola.
Summary of Fixes
\e,\<) in the Documentation annotation that caused OpenModelica lexer warnings.breakstatements fromFluid/PVTCollectors/Validation/PVT_UI/PVTQuasiDynamicCollectorValidation.moFluid/PVTCollectors/Validation/PVT_UN/PVTQuasiDynamicCollectorValidation.moA,B,C) which referenced protected constants not meant to appear inpackage.order.Impact