Fix cycle load issue #16 #18
Conversation
|
Who could review this? @bramvdh91 @SilkeVerbruggen |
|
I'm not sure what the calibration is so that's hard to answer for me. If the point of the calibration is to detect errors then I would do it individually. Otherwise you can probably do it only once. |
|
I can't do much in terms of reviewing, as I'm not familiar with how this part of the code works. Okay for me to just calibrate one for the two PRs. |
|
The calibration code changes the calibration factors ( |
|
Hi Christina, |
This commit should fix the
cycle_loadmodel inresidential.py, reported in #16 . However, calibration for these types of loads should still be done with the new model (updating thecalvalue inAppliances.py).Also note the model has some assumptions that could be changed, e.g. that the cycle length and delay are constant throughout the year, and that the power is the mean power assigned for that appliance (this could be sampled instead).