discovery_auth should accept True as well #137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iscsi> get discovery_auth DISCOVERY_AUTH CONFIG GROUP =========================== enable=False we should also be able to set it using True/False Signed-off-by: Maurizio Lombardi <[email protected]>
| enable = 1 | ||
| elif enable == 'False': | ||
| enable = 0 | ||
| elif int(enable): |
There was a problem hiding this comment.
I do not think the user know about python booleans always, so if they do false/true instead of False/True we will crash here due to int() not being able to convert it. I think it needs to be a enable.isdigit() or maybe a try/except ValueError to detect bad input. Whatever we normally do for input validation I guess.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
get discovery_auth is reporting True/False:
iscsi > get discovery_authDISCOVERY_AUTH CONFIG GROUPenable=Falsewe should also be able to set it using True/False, not only 1 or 0.
Signed-off-by: Maurizio Lombardi [email protected]