Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add workflows for pre-commit and PyPI release #205

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

martinhoyer
Copy link
Contributor

The simple linting step uses the existing pre-commit config and https://github.com/pre-commit/action. The action could be replaced with https://pre-commit.ci/, as needed.

Release step uses the reference setup from https://docs.pypi.org/trusted-publishers/.
It would be trigger once release is created here on github.

@martinhoyer
Copy link
Contributor Author

I'm thinking we might want to add

  workflow_dispatch:
    inputs:
      ref:
        description: 'Tag to release'
        required: true

to the publish step, to make sure each release is tagged (otherwise the package version would be invalid).

Or do you think it's redundant and no-one would create a release without a tag anyway?

@martinhoyer
Copy link
Contributor Author

Sneaking in a fix for an issue introduced while refactoring, where the shell would exit on errors like "Command not found"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant