Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Ubuntu and Debian Package creation with Cmake #590

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

DifanZhang
Copy link

Verified on Debian buster and Ubuntu bionic. The following patch creates Debian package for Debian based OS.

@mikechristie
Copy link
Collaborator

It looks like you and @JKJameson are trying to do the same things here and in

#589

Please take a look at each others PRs.

@@ -47,6 +47,11 @@ set(CPACK_DEBIAN_PACKAGE_MAINTAINER "Target Devel <[email protected]>
set(CPACK_DEBIAN_PACKAGE_HOMEPAGE "https://github.com/open-iscsi/tcmu-runner")
include(CPack)

Copy link
Collaborator

@mikechristie mikechristie Sep 3, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you need to rebase and repush by doing a forced push, so we do not end up seeing this in the final pull and commit.

If everyone adds junk like this then it gets messy in the main git tree.

[edit]

That comment was for the commit:

Merge branch 'master' into master
@DifanZhang
DifanZhang committed 19 hours ago

@@ -225,7 +225,7 @@ endif (with-zbc)

if (with-rbd)
find_library(LIBRBD rbd)
set(CPACK_DEBIAN_PACKAGE_DEPENDS "${CPACK_DEBIAN_PACKAGE_DEPENDS}, librados2, librbd1")
set(CPACK_DEBIAN_PACKAGE_DEPENDS "${CPACK_DEBIAN_PACKAGE_DEPENDS}, librados2, librbd1")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just make the first patch "Add preliminary support to build Debian packages with Cmake infrastru…" use tabs from the beginning.

@JuniorJPDJ
Copy link
Contributor

This probably should be closed as #589 is merged already.

@lxbsz
Copy link
Collaborator

lxbsz commented Jul 14, 2021

This probably should be closed as #589 is merged already.

The #589 is only supporting the extra/install_dep.sh, not sure whether will it work for the cmake ? I never test it yet on ubuntu/debian.

@lxbsz lxbsz changed the base branch from master to main August 10, 2022 00:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants