Support Ubuntu and Debian Package creation with Cmake #590
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like you and @JKJameson are trying to do the same things here and in Please take a look at each others PRs. |
mikechristie
reviewed
Sep 3, 2019
| @@ -47,6 +47,11 @@ set(CPACK_DEBIAN_PACKAGE_MAINTAINER "Target Devel <[email protected]> | |||
| set(CPACK_DEBIAN_PACKAGE_HOMEPAGE "https://github.com/open-iscsi/tcmu-runner") | |||
| include(CPack) | |||
|
|
|||
There was a problem hiding this comment.
I think you need to rebase and repush by doing a forced push, so we do not end up seeing this in the final pull and commit.
If everyone adds junk like this then it gets messy in the main git tree.
[edit]
That comment was for the commit:
Merge branch 'master' into master
@DifanZhang
DifanZhang committed 19 hours ago
mikechristie
reviewed
Sep 3, 2019
| @@ -225,7 +225,7 @@ endif (with-zbc) | |||
|
|
|||
| if (with-rbd) | |||
| find_library(LIBRBD rbd) | |||
| set(CPACK_DEBIAN_PACKAGE_DEPENDS "${CPACK_DEBIAN_PACKAGE_DEPENDS}, librados2, librbd1") | |||
| set(CPACK_DEBIAN_PACKAGE_DEPENDS "${CPACK_DEBIAN_PACKAGE_DEPENDS}, librados2, librbd1") | |||
There was a problem hiding this comment.
Just make the first patch "Add preliminary support to build Debian packages with Cmake infrastru…" use tabs from the beginning.
Merged
|
This probably should be closed as #589 is merged already. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Verified on Debian buster and Ubuntu bionic. The following patch creates Debian package for Debian based OS.