Match exactly against cfgstring #691
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Wondering if someone is able to take a look at this PR please? |
|
And also for this could you fix the commit comments as in #693 ? Thanks, |
lxbsz
reviewed
Feb 21, 2023
geordieintheshellcode
force-pushed
the
match-exactly-against-cfgstring
branch
from
9611e40
to
93122af
Compare
Ensure we pattern match 'cfgstring' against handler type exactly. Ensure we pattern match the cfgstring prefix against 'tcm-user' exactly. Signed-off-by: Alex Reid <[email protected]>
geordieintheshellcode
force-pushed
the
match-exactly-against-cfgstring
branch
from
93122af
to
f505ac2
Compare
|
Comments addressed and commit comment fixed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two bug fixes:
find_handlerensure thathandler->subtypeand the config string match exactly. The previous code would erroneously match config strings which were a prefix match ofhandler->subtype. For example, the config string "foo" would erroneously match against the subtype "foobar".