Skip to content

Commit

Permalink
sync: less config is more (fixes #5085) (#5098)
Browse files Browse the repository at this point in the history
Co-authored-by: dogi <[email protected]>
  • Loading branch information
huitk and dogi authored Jan 24, 2025
1 parent ba21c71 commit 31bd6cf
Show file tree
Hide file tree
Showing 9 changed files with 2 additions and 16 deletions.
8 changes: 2 additions & 6 deletions app/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,8 @@ android {
applicationId "org.ole.planet.myplanet"
minSdkVersion 26
targetSdkVersion 34
versionCode 2235
versionName "0.22.35"
versionCode 2236
versionName "0.22.36"
ndkVersion '21.3.6528147'
testInstrumentationRunner "androidx.test.runner.AndroidJUnitRunner"
vectorDrawables.useSupportLibrary = true
Expand Down Expand Up @@ -101,8 +101,6 @@ android {
def planetCambridgePin = project.findProperty('PLANET_CAMBRIDGE_PIN') ?: ""
//def planetEgdirbmacUrl = project.findProperty('PLANET_EGDIRBMAC_URL') ?: ""
//def planetEgdirbmacPin = project.findProperty('PLANET_EGDIRBMAC_PIN') ?: ""
def planetPalmBayUrl = project.findProperty('PLANET_PALMBAY_URL') ?: ""
def planetPalmBayPin = project.findProperty('PLANET_PALMBAY_PIN') ?: ""

buildTypes.each {
it.buildConfigField 'String', 'PLANET_LEARNING_URL', "\"$planetLearningUrl\""
Expand Down Expand Up @@ -135,8 +133,6 @@ android {
it.buildConfigField 'String', 'PLANET_CAMBRIDGE_PIN', "\"${planetCambridgePin}\""
//it.buildConfigField 'String', 'PLANET_EGDIRBMAC_URL', "\"${planetEgdirbmacUrl}\""
//it.buildConfigField 'String', 'PLANET_EGDIRBMAC_PIN', "\"${planetEgdirbmacPin}\""
it.buildConfigField 'String', 'PLANET_PALMBAY_URL', "\"${planetPalmBayUrl}\""
it.buildConfigField 'String', 'PLANET_PALMBAY_PIN', "\"${planetPalmBayPin}\""
}
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -609,7 +609,6 @@ abstract class SyncActivity : ProcessUserDataActivity(), SyncListener, CheckVers
ServerAddressesModel(getString(R.string.sync_embakasi), BuildConfig.PLANET_EMBAKASI_URL),
ServerAddressesModel(getString(R.string.sync_cambridge), BuildConfig.PLANET_CAMBRIDGE_URL),
//ServerAddressesModel(getString(R.string.sync_egdirbmac), BuildConfig.PLANET_EGDIRBMAC_URL),
ServerAddressesModel(getString(R.string.sync_palmbay), BuildConfig.PLANET_PALMBAY_URL)
)

val storedUrl = settings.getString("serverURL", null)
Expand Down Expand Up @@ -704,7 +703,6 @@ abstract class SyncActivity : ProcessUserDataActivity(), SyncListener, CheckVers
BuildConfig.PLANET_EMBAKASI_URL to BuildConfig.PLANET_EMBAKASI_PIN,
BuildConfig.PLANET_CAMBRIDGE_URL to BuildConfig.PLANET_CAMBRIDGE_PIN,
// BuildConfig.PLANET_EGDIRBMAC_URL to BuildConfig.PLANET_EGDIRBMAC_PIN,
BuildConfig.PLANET_PALMBAY_URL to BuildConfig.PLANET_PALMBAY_PIN
)
return pinMap[url] ?: ""
}
Expand Down
1 change: 0 additions & 1 deletion app/src/main/res/values-ar/strings.xml
Original file line number Diff line number Diff line change
Expand Up @@ -1137,7 +1137,6 @@
<string name="sync_embakasi">🇰🇪 planet embakasi</string>
<string name="sync_cambridge">🇺🇸 planet cambridge</string>
<string name="sync_egdirbmac">🇺🇸 planet egdirbmac</string>
<string name="sync_palmbay">🇺🇸 planet palmbay</string>
<string name="surveys_to_complete">لديك %1$d %2$s لإكماله</string>
<string name="show_less">عرض أقل</string>
<string name="show_more">عرض المزيد</string>
Expand Down
1 change: 0 additions & 1 deletion app/src/main/res/values-es/strings.xml
Original file line number Diff line number Diff line change
Expand Up @@ -1136,7 +1136,6 @@
<string name="sync_embakasi">🇰🇪 planet embakasi</string>
<string name="sync_cambridge">🇺🇸 planet cambridge</string>
<string name="sync_egdirbmac">🇺🇸 planet egdirbmac</string>
<string name="sync_palmbay">🇺🇸 planet palmbay</string>
<string name="surveys_to_complete">Tienes %1$d %2$s para completar</string>
<string name="show_less">mostrar menos</string>
<string name="show_more">mostrar más</string>
Expand Down
1 change: 0 additions & 1 deletion app/src/main/res/values-fr/strings.xml
Original file line number Diff line number Diff line change
Expand Up @@ -1137,7 +1137,6 @@
<string name="sync_embakasi">🇰🇪 planet embakasi</string>
<string name="sync_cambridge">🇺🇸 planet cambridge</string>
<string name="sync_egdirbmac">🇺🇸 planet egdirbmac</string>
<string name="sync_palmbay">🇺🇸 planet palmbay</string>
<string name="surveys_to_complete">Vous avez %1$d %2$s à compléter</string>
<string name="show_less">montrer moins</string>
<string name="show_more">montrer plus</string>
Expand Down
1 change: 0 additions & 1 deletion app/src/main/res/values-ne/strings.xml
Original file line number Diff line number Diff line change
Expand Up @@ -1137,7 +1137,6 @@
<string name="sync_embakasi">🇰🇪 planet embakasi</string>
<string name="sync_cambridge">🇺🇸 planet cambridge</string>
<string name="sync_egdirbmac">🇺🇸 planet egdirbmac</string>
<string name="sync_palmbay">🇺🇸 planet palmbay</string>
<string name="surveys_to_complete">तपाईंको %1$d %2$s पूरा गर्न बाँकी छ</string>
<string name="show_less">कम देखाउनुहोस्</string>
<string name="show_more">थप देखाउनुहोस्</string>
Expand Down
1 change: 0 additions & 1 deletion app/src/main/res/values-so/strings.xml
Original file line number Diff line number Diff line change
Expand Up @@ -1137,7 +1137,6 @@
<string name="sync_embakasi">🇰🇪 planet embakasi</string>
<string name="sync_cambridge">🇺🇸 planet cambridge</string>
<string name="sync_egdirbmac">🇺🇸 planet egdirbmac</string>
<string name="sync_palmbay">🇺🇸 planet palmbay</string>
<string name="surveys_to_complete">Waxaad haysataa %1$d %2$s oo ay tahay inaad dhammaystirto</string>
<string name="show_less">tus wax yar</string>
<string name="show_more">tus wax badan</string>
Expand Down
1 change: 0 additions & 1 deletion app/src/main/res/values/strings.xml
Original file line number Diff line number Diff line change
Expand Up @@ -1137,7 +1137,6 @@
<string name="sync_embakasi">🇰🇪 planet embakasi</string>
<string name="sync_cambridge">🇺🇸 planet cambridge</string>
<string name="sync_egdirbmac">🇺🇸 planet egdirbmac</string>
<string name="sync_palmbay">🇺🇸 planet palmbay</string>
<string name="surveys_to_complete">You have %1$d %2$s to complete</string>
<string name="show_less">show less</string>
<string name="show_more">show more</string>
Expand Down
2 changes: 0 additions & 2 deletions gradle.properties
Original file line number Diff line number Diff line change
Expand Up @@ -54,5 +54,3 @@ PLANET_CAMBRIDGE_PIN=6407
# took egdirbmac cause planet on cambridge is at 8080
#PLANET_EGDIRBMAC_URL=planet.cambridge.ole.org
#PLANET_EGDIRBMAC_PIN=1565
PLANET_PALMBAY_URL=planet.palmbay.ole.org
PLANET_PALMBAY_PIN=9699

0 comments on commit 31bd6cf

Please sign in to comment.