Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

teams: smoother resource remove (fixes #4916) #4917

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Original file line number Diff line number Diff line change
Expand Up @@ -11,10 +11,15 @@ import org.ole.planet.myplanet.callback.OnHomeItemClickListener
import org.ole.planet.myplanet.databinding.RowTeamResourceBinding
import org.ole.planet.myplanet.model.RealmMyLibrary
import org.ole.planet.myplanet.model.RealmMyTeam.Companion.getTeamCreator
import org.ole.planet.myplanet.ui.team.teamResource.AdapterTeamResource.ViewHolderTeamResource

class AdapterTeamResource(private val context: Context, private val list: List<RealmMyLibrary>, mRealm: Realm, teamId: String?, private val settings: SharedPreferences) : RecyclerView.Adapter<ViewHolderTeamResource>() {
private lateinit var rowTeamResourceBinding: RowTeamResourceBinding
class AdapterTeamResource(
private val context: Context,
private val list: MutableList<RealmMyLibrary>,
private val mRealm: Realm,
teamId: String?,
private val settings: SharedPreferences
) : RecyclerView.Adapter<AdapterTeamResource.ViewHolderTeamResource>() {

private var listener: OnHomeItemClickListener? = null
private val teamCreator: String = getTeamCreator(teamId, mRealm)

Expand All @@ -25,25 +30,48 @@ class AdapterTeamResource(private val context: Context, private val list: List<R
}

override fun onCreateViewHolder(parent: ViewGroup, viewType: Int): ViewHolderTeamResource {
rowTeamResourceBinding = RowTeamResourceBinding.inflate(LayoutInflater.from(context), parent, false)
return ViewHolderTeamResource(rowTeamResourceBinding)
val binding = RowTeamResourceBinding.inflate(LayoutInflater.from(context), parent, false)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is these being renamed?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Okuro3499 , reverted variable names

return ViewHolderTeamResource(binding)
}

override fun onBindViewHolder(holder: ViewHolderTeamResource, position: Int) {
rowTeamResourceBinding.tvTitle.text = list[position].title
rowTeamResourceBinding.tvDescription.text = list[position].description
val resource = list[position]

holder.binding.tvTitle.text = resource.title
holder.binding.tvDescription.text = resource.description

holder.itemView.setOnClickListener {
listener?.openLibraryDetailFragment(list[position])
listener?.openLibraryDetailFragment(resource)
}
rowTeamResourceBinding.ivRemove.setOnClickListener { }
if (!settings.getString("userId", "--").equals(teamCreator, ignoreCase = true)) {
rowTeamResourceBinding.ivRemove.visibility = View.GONE

holder.binding.ivRemove.setOnClickListener {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these ones too from rowTeamResourceBinding to holder.binding.

Copy link
Member Author

@deeppp15 deeppp15 Jan 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Okuro3499 , reverted variable names

removeResource(resource, position)
}

holder.binding.ivRemove.visibility = if (settings.getString("userId", "--") == teamCreator) {
View.VISIBLE
} else {
View.GONE
}
}

override fun getItemCount(): Int {
return list.size
}

class ViewHolderTeamResource(rowTeamResourceBinding: RowTeamResourceBinding) : RecyclerView.ViewHolder(rowTeamResourceBinding.root)
fun removeResource(resource: RealmMyLibrary, position: Int) {
if (position < 0 || position >= list.size) return

mRealm.executeTransaction { realm ->
val itemToDelete = realm.where(RealmMyLibrary::class.java)
.equalTo("id", resource.id)
.findFirst()
itemToDelete?.deleteFromRealm()
}

list.removeAt(position)
notifyItemRemoved(position)
}

class ViewHolderTeamResource(val binding: RowTeamResourceBinding) : RecyclerView.ViewHolder(binding.root)
}
Original file line number Diff line number Diff line change
Expand Up @@ -47,8 +47,14 @@ class TeamResourceFragment : BaseTeamFragment(), TeamPageListener {
}

private fun showLibraryList() {
val libraries: List<RealmMyLibrary> = mRealm.where(RealmMyLibrary::class.java).`in`("id", getResourceIds(teamId, mRealm).toTypedArray<String>()).findAll()
adapterLibrary = settings?.let { AdapterTeamResource(requireActivity(), libraries, mRealm, teamId, it) }!!
val libraries: MutableList<RealmMyLibrary> = mRealm.where(RealmMyLibrary::class.java)
.`in`("id", getResourceIds(teamId, mRealm).toTypedArray())
.findAll()
.toMutableList()

adapterLibrary = settings?.let {
AdapterTeamResource(requireActivity(), libraries, mRealm, teamId, it)
}!!
fragmentTeamResourceBinding.rvResource.layoutManager = GridLayoutManager(activity, 3)
fragmentTeamResourceBinding.rvResource.adapter = adapterLibrary
showNoData(fragmentTeamResourceBinding.tvNodata, adapterLibrary.itemCount, "teamResources")
Expand Down
Loading