-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
library: smoother selectall checkbox (fixes #4993) #5028
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
when all are selected unselecting one item toggles the checkbox to select all and reselecting it toggles the checkbox to unselect all. This isn't the case after navigating to library details and back
Screen_recording_20250115_153319.webm
|
||
selectAll.setOnClickListener { | ||
selectAll.setOnCheckedChangeListener { _, isChecked -> | ||
if (isProgrammaticChange) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could you also rename this to a more understandable term of what exactly is happenning isProgrammaticChange is quite vague not easy to understand what is happening
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
when all are selected unselecting one item toggles the checkbox to select all and reselecting it toggles the checkbox to unselect all. This isn't the case after navigating to library details and back
Screen_recording_20250115_153319.webm
@pavi38 this issue is still persistent
@pavi38 another solution is unselecting everything if the select all is checked and user clicks a resource |
fixes #4993
Screen.Recording.2025-01-14.at.1.44.08.PM.mov