Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

library: smoother selectall checkbox (fixes #4993) #5028

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

pavi38
Copy link
Member

@pavi38 pavi38 commented Jan 14, 2025

fixes #4993

Screen.Recording.2025-01-14.at.1.44.08.PM.mov

Copy link
Collaborator

@Okuro3499 Okuro3499 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

when all are selected unselecting one item toggles the checkbox to select all and reselecting it toggles the checkbox to unselect all. This isn't the case after navigating to library details and back
Screen_recording_20250115_153319.webm


selectAll.setOnClickListener {
selectAll.setOnCheckedChangeListener { _, isChecked ->
if (isProgrammaticChange) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you also rename this to a more understandable term of what exactly is happenning isProgrammaticChange is quite vague not easy to understand what is happening

Okuro3499
Okuro3499 previously approved these changes Jan 15, 2025
@Okuro3499 Okuro3499 dismissed their stale review January 15, 2025 19:28

issue wasn't fixed

Copy link
Collaborator

@Okuro3499 Okuro3499 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

when all are selected unselecting one item toggles the checkbox to select all and reselecting it toggles the checkbox to unselect all. This isn't the case after navigating to library details and back
Screen_recording_20250115_153319.webm

@pavi38 this issue is still persistent

@Okuro3499
Copy link
Collaborator

@pavi38 you solved a similar issue in #5021 replicate the same here

@Okuro3499
Copy link
Collaborator

@pavi38 another solution is unselecting everything if the select all is checked and user clicks a resource

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

library select all malfunction
4 participants