Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

language: smoother translations (fixes #5222) #5309

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

language: smoother translations (fixes #5222) #5309

wants to merge 3 commits into from
+57 −39

Conversation

Avinash-Codes
Copy link
Member

fixes #5222

@Avinash-Codes Avinash-Codes linked an issue Feb 19, 2025 that may be closed by this pull request
navbar: add translate button/icon #5222
Open
@Avinash-Codes Avinash-Codes changed the title language: smoother language translate (fixes #5222) language: smoother translate (fixes #5222) Feb 19, 2025
@Avinash-Codes Avinash-Codes changed the title language: smoother translate (fixes #5222) language: smoother translation (fixes #5222) Feb 19, 2025
@Avinash-Codes Avinash-Codes changed the title language: smoother translation (fixes #5222) language: smoother translations (fixes #5222) Feb 19, 2025
Okuro3499
Okuro3499 requested changes Feb 19, 2025
View reviewed changes
Copy link
Collaborator

@Okuro3499 Okuro3499 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can refactor to remove the one in the settings to avoid duplicate functionality

pavi38
pavi38 requested changes Feb 19, 2025
View reviewed changes
Copy link
Member

@pavi38 pavi38 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

when the open the menu in portrait mode and turn to landscape mode
Screenshot 2025-02-19 at 2 17 11 PM

Okuro3499
Okuro3499 approved these changes Feb 21, 2025
View reviewed changes
Copy link
Collaborator

@Okuro3499 Okuro3499 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pavi38 looks good for me on a tablet and a rotated phone. which emulator are you using
Screenshot_20250221_141712
Screenshot_20250221_140506

@Avinash-Codes Avinash-Codes requested a review from pavi38 February 21, 2025 15:22
@pavi38
Copy link
Member

pavi38 commented Feb 21, 2025

Hi @Okuro3499 I tested it on pixel 9 and medium phone

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@huitk huitk huitk approved these changes

@Okuro3499 Okuro3499 Okuro3499 approved these changes

@pavi38 pavi38 Awaiting requested review from pavi38

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
peer review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

navbar: add translate button/icon
4 participants
@Avinash-Codes @pavi38 @huitk @Okuro3499