Fix(test): Sample usage python tests #24618
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Ingestion
safe to test
mohittilala
added
the
To release
mohittilala
changed the title
ulixius9
approved these changes
Dec 1, 2025
|
Contributor
|
Changes have been cherry-picked to the 1.11.0 branch. |
github-actions bot
pushed a commit
that referenced
this pull request
Dec 1, 2025
* test: add comprehensive debug logging to sample usage test * Increase default lineage query parsing timeout from 10 to 30 sec * test: add LineageParser 300s timeout test for CI performance measurement * test: add lineage parser perf test to main test * Correct query_log query with correct values and revert all debug code of test * Revert parsing timeout to 10sec * Update parsing timeout to 30sec and add debug tests to check time took on query * Intentional failure to log query parsing time in CI * Remove debug tests (cherry picked from commit 1efaab9)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes:
Fix below test in all python CI,
FAILED ingestion/tests/unit/test_sample_usage.py::QueryParserTest::test_join_countUPDATE:
This started failing due to breaking changes of latest update sqlparse==0.5.4 (Nov 28, 2025). Additionally, query we have at
ingestion/examples/sample_data/datasets/query_logwas invalid with?masking character that bypassed sqlfluff parser and fallback to sqlfluff of this latest version. We didn't face this error earlier since it was handling this invalid query as well but now, we have addressed these both cases.Type of change:
Checklist:
Fixes <issue-number>: <short explanation>