Addressed PR comments

Signed-off-by: Ilia Yastrebov <[email protected]>
open-mpi · Feb 5, 2024 · 5a61d50 · 5a61d50
1 parent f23365e
commit 5a61d50
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/oshmem/mca/spml/ucx/spml_ucx.h b/oshmem/mca/spml/ucx/spml_ucx.h
@@ -43,6 +43,7 @@ BEGIN_C_DECLS
 
 #define SPML_UCX_ASSERT  MCA_COMMON_UCX_ASSERT
 #define SPML_UCX_ERROR   MCA_COMMON_UCX_ERROR
+#define SPML_UCX_WARN    MCA_COMMON_UCX_WARN
 #define SPML_UCX_VERBOSE MCA_COMMON_UCX_VERBOSE
 #define SPML_UCX_TRANSP_IDX 0
 #define SPML_UCX_TRANSP_CNT 1

diff --git a/oshmem/mca/spml/ucx/spml_ucx_component.c b/oshmem/mca/spml/ucx/spml_ucx_component.c
@@ -492,11 +492,10 @@ static int mca_spml_ucx_component_fini(void)
 
 
     ret = opal_common_ucx_mca_pmix_fence_nb(&fenced);
-    if (ret == PMIX_ERR_UNREACH) {
-        /* It's ok if we are disconnected, continue cleanup */
+    if (ret != PMIX_SUCCESS) {
+        SPML_UCX_WARN("pmix fence failed: %d", ret);
+        /* In case of pmix fence failure just continue cleanup */
         fenced = 1;
-    } else if (ret != PMIX_SUCCESS) {
-        return ret;
     }
 
     while (!fenced) {