coll/han: fix bug in reduce in place #11800
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wzamazon
force-pushed
the
coll_han_fix_reduce_in_place
branch
from
ce4d807
to
01f552b
Compare
|
@B-a-S Looks like a failure in the NVIDIA CI environment: Can you please investigate? |
wzamazon
force-pushed
the
coll_han_fix_reduce_in_place
branch
2 times, most recently
from
da87fdc
to
dc3b21a
Compare
bwbarrett
requested changes
Jul 10, 2023
wzamazon
force-pushed
the
coll_han_fix_reduce_in_place
branch
from
dc3b21a
to
93bfdd5
Compare
|
CI infra issue has been resolved. @bosilca Can you review? |
wzamazon
force-pushed
the
coll_han_fix_reduce_in_place
branch
from
93bfdd5
to
9ba0637
Compare
bwbarrett
approved these changes
Jul 11, 2023
Piror to this patch, the reduce code try to applied arithematic operations on a sendbuf, even when it is MPI_IN_PLACE. this patch addressed the issue. Signed-off-by: Wei Zhang <[email protected]>
wzamazon
force-pushed
the
coll_han_fix_reduce_in_place
branch
from
9ba0637
to
d520921
Compare
|
all CI passed. Ready for merge! |
|
@wzamazon It says you force-pushed an hour ago. What did you push after the PR was approved? |
I rebased to latest main branch (using the github's rebase branch option) |
Ok. In our community, there's generally no need to do that unless a specific reason for why it's necessary. Otherwise, it just brings up the question "what changed?" 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Piror to this patch, the reduce code try to applied arithematic operations on a sendbuf, even when it
is MPI_IN_PLACE. this patch addressed the issue.