Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

accelerator: build components as dso's by default #12055

Merged
merged 2 commits into from
Dec 13, 2023
Merged

accelerator: build components as dso's by default #12055

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8601eb5
accelerator: build components as dso's by default
hppritcha Nov 7, 2023
9580fd5
quashme: pr feedback
hppritcha Dec 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 17 additions & 13 deletions config/opal_mca.m4
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ dnl All rights reserved.
dnl Copyright (c) 2010-2021 Cisco Systems, Inc. All rights reserved
dnl Copyright (c) 2013-2017 Intel, Inc. All rights reserved.
dnl Copyright (c) 2018-2022 Amazon.com, Inc. or its affiliates. All Rights reserved.
dnl Copyright (c) 2021 Triad National Security, LLC. All rights
dnl Copyright (c) 2021-2023 Triad National Security, LLC. All rights
dnl reserved.
dnl $COPYRIGHT$
dnl
Expand Down Expand Up @@ -167,32 +167,36 @@ of type-component pairs. For example, --enable-mca-no-build=pml-ob1])
# Second, set the DSO_all and STATIC_all variables. conflict
# resolution (prefer static) is done in the big loop below
#
# Exception here is the components of the accelerator framework,
# which by default are built to be dynamic, except for null.
#
AC_MSG_CHECKING([which components should be run-time loadable])
if test "$enable_static" != "no"; then
DSO_all=0
msg="none (static libraries built)"
elif test "$OPAL_ENABLE_DLOPEN_SUPPORT" = 0; then
DSO_all=0
msg="none (dlopen disabled)"
elif test -z "$enable_mca_dso"; then
DSO_all=0
msg=default
elif test "$enable_mca_dso" = "no"; then
DSO_all=0
msg=none
elif test "$enable_mca_dso" = "yes"; then
DSO_all=1
msg=all
else
DSO_all=0
ifs_save="$IFS"
IFS="${IFS}$PATH_SEPARATOR,"
msg=
for item in $enable_mca_dso; do
AS_VAR_SET([AS_TR_SH([DSO_$item])], [1])
msg="$item $msg"
done
IFS="$ifs_save"
msg=
if test -z "$enable_mca_dso"; then
enable_mca_dso="accelerator-cuda,accelerator-rocm,accelerator-ze,btl-smcuda,rcache-gpusm,rcache-rgpusm"
msg="(default)"
jsquyres marked this conversation as resolved.
Show resolved Hide resolved
fi
jsquyres marked this conversation as resolved.
Show resolved Hide resolved
DSO_all=0
ifs_save="$IFS"
IFS="${IFS}$PATH_SEPARATOR,"
for item in $enable_mca_dso; do
AS_VAR_SET([AS_TR_SH([DSO_$item])], [1])
msg="$item $msg"
done
IFS="$ifs_save"
fi
AC_MSG_RESULT([$msg])
unset msg
Expand Down