Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

osc/rdma: fix compiler warnings in osc_rdma_accumulate.c #12154

Merged
merged 1 commit into from
Dec 12, 2023
Merged

osc/rdma: fix compiler warnings in osc_rdma_accumulate.c #12154

merged 1 commit into from
Dec 12, 2023

Conversation

devreal
Copy link
Contributor

@devreal devreal commented Dec 8, 2023

Ensure const-correctness of the compare_addr argument to atomic CAS.

Fixes #12130

@devreal
osc/rdma: fix compiler warnings in osc_rdma_accumulate.c
1360be4 
Ensure const-correctness of the compare_addr argument to atomic CAS.

Signed-off-by: Joseph Schuchart <[email protected]>
janjust
janjust approved these changes Dec 8, 2023
View reviewed changes
Copy link
Contributor

@janjust janjust left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@devreal can you cherry pick to v5.0.x?

@devreal
Copy link
Contributor Author

devreal commented Dec 8, 2023

Done: #12155

@wenduwan wenduwan mentioned this pull request Dec 11, 2023
Merged
jsquyres
jsquyres approved these changes Dec 11, 2023
View reviewed changes
Copy link
Member

@jsquyres jsquyres left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a creative way to cast away the const. If that's all this is, cool -- glad it's not a larger issue (I wasn't sure, which is why I filed #12130). I confirm that this fix does, indeed, remove the compiler warnings. Thanks @devreal!

@devreal devreal merged commit ab4cd38 into open-mpi:main Dec 12, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsquyres jsquyres jsquyres approved these changes

@janjust janjust janjust approved these changes

Assignees
No one assigned
Labels
Target: main
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Concerning warnings in OSC rdma
3 participants
@devreal @jsquyres @janjust