Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

submodules: bump prrte and pmix pointers to latest release tags #12170

Merged
merged 1 commit into from
Dec 19, 2023

Conversation

wenduwan
Copy link
Contributor

@wenduwan wenduwan commented Dec 19, 2023

This is to prepare for 5.0.1 release

bot:notacherrypick

Comment on lines 11 to +17
- Internal PMIx and PRRTe versions:

- PMIx (v4.2.8rc1-1-g0e09e062). Commit hash: ``0e09e062e8cefe0feb18ea37d768ded213053d68``.
- PRRTE (v3.0.3rc1-2-g33aa50909f). Commit hash: ``33aa50909fe2c223f9f515fae120cd6a21d04653``.
- PMIx (v4.2.8). Commit hash: ``d1c1ed0c2e64f19ad49291241a43630ea7fdce28``.
- PRRTE (v3.0.3). Commit hash: ``e383f5ad70c2633420d3425e9fb67e69b6bfd9c4``.

- Bugfixes and changes (in chronological order)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't worry about this. We will update the doc again.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For future releases, it would probably be good to automate this section of the doc (i.e., grab the specific git commits dynamically). It would be just a little less for a human to need to do, and probably be less error-prone.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes... though I also wonder if it is really necessary to include the commit hash. The release tag should be enough.

@github-actions github-actions bot added this to the v5.0.1 milestone Dec 19, 2023
Copy link

Hello! The Git Commit Checker CI bot found a few problems with this PR:

2b80ebc: submodules: bump prrte and pmix pointers to latest...

  • check_cherry_pick: does not include a cherry pick message (did you need to bot:notacherrypick?)

Please fix these problems and, if necessary, force-push new commits back up to the PR branch. Thanks!

This is to prepare for 5.0.1 release

bot:notacherrypick

Signed-off-by: Wenduo Wang <[email protected]>
@wenduwan
Copy link
Contributor Author

PR passed our internal CI.

@wenduwan wenduwan merged commit 0ce916c into open-mpi:v5.0.x Dec 19, 2023
13 checks passed
@wenduwan wenduwan deleted the 5.0.1_bump_submodules branch December 19, 2023 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants