mtl/ofi: avoid accessing request object after completion callback(restart ci) #12175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Testing in AWS internal CI. |
wenduwan
force-pushed
the
mt_completion_callback
branch
from
f07faa6
to
f5119b0
Compare
hppritcha
requested changes
Dec 21, 2023
ompi/mca/mtl/ofi/mtl_ofi.h
Outdated
| @@ -154,9 +154,9 @@ ompi_mtl_ofi_context_progress(int ctxt_id) | |||
| ret = ofi_req->event_callback(&ompi_mtl_ofi_wc[i], ofi_req); | |||
| if (OMPI_SUCCESS != ret) { | |||
| opal_output(0, | |||
| "%s:%d: Error returned by request (type: %d) event callback: %zd.\n" | |||
| "%s:%d: Error returned by request event callback: %zd.\n" | |||
There was a problem hiding this comment.
could you cache the req type before invoking the event_callback and use that in the error message? might help a little with debugging.
There was a problem hiding this comment.
Ah that's smart. Let me do that...
There was a problem hiding this comment.
Updated. Running our CI again...
wenduwan
force-pushed
the
mt_completion_callback
branch
2 times, most recently
from
27a9516
to
c90f848
Compare
wenduwan
changed the title
hppritcha
approved these changes
Dec 21, 2023
|
nvidia ci vomitted... |
|
rerunning it doesn't seem to help. |
|
It appears that the backend server is not available. I tried to restart the ci for #12182 |
Request completion callback function can potentially invalidate the request object. We should avoid accessing the object afterwards. Signed-off-by: Wenduo Wang <[email protected]>
wenduwan
force-pushed
the
mt_completion_callback
branch
from
c90f848
to
6d79aae
Compare
|
Finally worked... Our internal CI also passed. Merging... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The completion callback can potentially invalidate the request object, so it is not safe to access the object afterwards.