Update VERSION and NEWS for 5.0.1 #12177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wenduwan
force-pushed
the
5.0.1_release
branch
3 times, most recently
from
7265bbc
to
eee45be
Compare
janjust
approved these changes
Dec 20, 2023
jsquyres
reviewed
Dec 20, 2023
VERSION
Outdated
| @@ -41,7 +41,7 @@ flex_min_version=2.5.4 | |||
| # requirement is that it must be entirely printable ASCII characters | |||
| # and have no white space. | |||
|
|
|||
| greek=rc1 | |||
| greek=a1 | |||
There was a problem hiding this comment.
Don't you want to make this rc2?
We've already made a1 releases -- don't go backwards.
You can make a rc2 release tarball, and if it passes a few sanity tests, make a final tarball (without rc2). The Jenkins job has a parameter that will set greek to empty during the tarball build (i.e., you don't have to commit greek= in VERSION to make this happen).
There was a problem hiding this comment.
Ah you are right. We should only go forward.
Updated. Thanks!
bot:notacherrypick Signed-off-by: Wenduo Wang <[email protected]>
wenduwan
force-pushed
the
5.0.1_release
branch
from
eee45be
to
8899ab0
Compare
jsquyres
approved these changes
Dec 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bot:notacherrypick