-
Notifications
You must be signed in to change notification settings - Fork 859
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pmix: remove the MCA framework #12309
base: main
Are you sure you want to change the base?
Conversation
Which params are you concerned about? I think there were a couple of params in the pmix/base - are those the ones? If so, what I did in PRRTE was to add a param registration function in your If you mean the PMIx internal params, then that's been an ongoing discussion. I forget the OMPI issue number, but basically we had agreed on a method but nobody had time to implement it. |
The |
After this PR, the following bits have disappeared from My concern is if we cannot fix that, that could be a deal breaker for
|
pmix is now a first class citizen and hence do not need to be part of a MCA framework anymore Refs. open-mpi#12282 Signed-off-by: Gilles Gouaillardet <[email protected]>
48cf38d
to
d349b1a
Compare
@ggouaillardet Would you like me to fix the param issue for you? Having done it before, it should only take a few minutes to port it here. |
I came up with this (plus a missing trivial fix) diff --git a/opal/mca/common/ofi/common_ofi.c b/opal/mca/common/ofi/common_ofi.c
index d39412f..ed63c95 100644
--- a/opal/mca/common/ofi/common_ofi.c
+++ b/opal/mca/common/ofi/common_ofi.c
@@ -34,7 +34,6 @@
#include "opal/mca/base/mca_base_var.h"
#include "opal/mca/hwloc/base/base.h"
#include "opal/mca/memory/base/base.h"
-#include "opal/mca/pmix/base/base.h"
#include "opal/util/argv.h"
#include "opal/util/show_help.h"
diff --git a/opal/runtime/opal_info_support.c b/opal/runtime/opal_info_support.c
index e167451..437163f 100644
--- a/opal/runtime/opal_info_support.c
+++ b/opal/runtime/opal_info_support.c
@@ -340,6 +340,7 @@ void opal_info_register_types(opal_pointer_array_t *mca_types)
for (i = 0; NULL != opal_frameworks[i]; i++) {
opal_pointer_array_add(mca_types, opal_frameworks[i]->framework_name);
}
+ opal_pointer_array_add(mca_types, "pmix");
}
int opal_info_register_framework_params(opal_pointer_array_t *component_map) If there is a better way, feel free to suggest or push in this PR directly. I still believe we should find a way to keep |
Looks like this does the trick
|
Yep, that's all there is to it for the params. However, I don't think this patch is entirely correct. You don't want to declare this still to be a framework by calling |
pmix is now a first class citizen and hence do not need to be part of a MCA framework anymore
Refs. #12282